Closed
Bug 545756
Opened 14 years ago
Closed 14 years ago
Get rid of quit-application observer
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.1
People
(Reporter: zpao, Assigned: zpao)
Details
Attachments
(1 file)
|
2.80 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
We're observing quit-application and then calling a method that doesn't exist. We should just get rid of all of that. Note: _onQuitApplication was removed in http://hg.mozilla.org/labs/weave/rev/53769570c48a
|
Assignee | |
Comment 1•14 years ago
|
||
Removes observer & isQuitting since it isn't used anywhere.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 426603 [details] [diff] [review] Patch v0.1 Yeah seems like this has been unused for a while. The isQuitting flag used to be for some UI bits to decide if it should show a menu item or allow syncing.
Attachment #426603 -
Flags: review?(edilee) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed http://hg.mozilla.org/labs/weave/rev/61534ca7e204 Stop observing 'quit-application', remove handling from observe, and remove WeaveSvc.isQuitting
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.1
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•