Last Comment Bug 545771 - Double accesskey 'n' for 'Unsubscribe' and 'Preferences' for newsgroups [linux]
: Double accesskey 'n' for 'Unsubscribe' and 'Preferences' for newsgroups [linux]
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Toolbars and Tabs (show other bugs)
: 3.0
: x86 Linux
: -- minor (vote)
: Thunderbird 13.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-11 15:33 PST by Karsten Düsterloh
Modified: 2012-02-14 04:36 PST (History)
4 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.25 KB, patch)
2012-01-30 12:17 PST, :aceman
bwinton: review+
bwinton: ui‑review+
Details | Diff | Review

Description Karsten Düsterloh 2010-02-11 15:33:24 PST
Shredder 3.0.2pre, Linux 64 bit debug build.

steps to reproduce:
- select newsgroup and make sure it has the focus 
- hit alt-e to open the Edit menu
- hit n to open Preferences

expected result:
Preferences dialog opens

actual result:
'Unsubscribe' menuitem is selected, you need hit n again to select the Prefences entry and hit return to open the Preferences dialog

possible solution:
switch Preferences accesskey to e again?
Comment 1 :aceman 2011-11-13 10:41:29 PST
Or change the access key of the less common Unsubscribe item?
Comment 2 :aceman 2012-01-30 06:32:07 PST
I am able to change accesskeys, I just need a UI decision here.
Comment 3 :aceman 2012-01-30 11:00:18 PST
Ian Neal, is this relevant for Seamonkey too? It also uses "n" for Unsubscribe but I do not know what other menu items are there and if it clashes with anything.

My suggestion for Thunderbird is to change unsubscribeNewsgroupCmd.accesskey to 'b' as that is not yet used in the Edit menu.
I think it is better to change accesskey for the Unsubscribe command instead of Preferences. Preferences is always there and probably more known so keeping it unchanged is higher gain.
Comment 4 Ian Neal 2012-01-30 11:10:07 PST
(In reply to :aceman from comment #3)
> Ian Neal, is this relevant for Seamonkey too? It also uses "n" for
> Unsubscribe but I do not know what other menu items are there and if it
> clashes with anything.
> 
> My suggestion for Thunderbird is to change unsubscribeNewsgroupCmd.accesskey
> to 'b' as that is not yet used in the Edit menu.
> I think it is better to change accesskey for the Unsubscribe command instead
> of Preferences. Preferences is always there and probably more known so
> keeping it unchanged is higher gain.

e is used for Preferences on SM. SM uses a different preferences dialog and nothing on any of the pref panes that is opened uses "e" as an accesskey, so I'm not sure if SM is affected. Karsten might know though.
Comment 5 :aceman 2012-01-30 11:15:44 PST
This is talking only about Edit menu. If your Preferences menu item does not use "n" then you are not affected and I will not touch SM. Thanks.
Comment 6 :aceman 2012-01-30 12:17:05 PST
Created attachment 592820 [details] [diff] [review]
patch

Change accesskey for Unsubscribe to 'b'. Reasoning in comment 3.
Comment 7 Blake Winton (:bwinton) (:☕️) (PTO 'til London. Find me there for quick answers!) 2012-02-13 16:30:15 PST
Comment on attachment 592820 [details] [diff] [review]
patch

Seems reasonable, and reasonably well thought-out.

ui-r=me, and since I'm here, r=me, too.

Thanks,
Blake.
Comment 8 :aceman 2012-02-14 00:19:46 PST
Thanks!
Comment 9 Mark Banner (:standard8) 2012-02-14 04:36:59 PST
Checked in: http://hg.mozilla.org/comm-central/rev/37481eaa6c69

Note You need to log in before you can comment on or make changes to this bug.