545833 - tinderboxpushlog: fails to load with non-permanent cookies and dom.storage disabled

Status: VERIFIED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Kai Engert [:KaiE:]]

http://tests.themasta.com/tinderboxpushlog/

For me, page indicates its loading, but nothing happens, forever.

It took me a while to check all my prefs and I identified the cause are my privacy settings:

user_pref("network.cookie.lifetimePolicy", 1);
user_pref("dom.storage.enabled", false);

If the page depends on those prefs, the page should at least warn about this dependency.

Comment 1

[Markus Stange [:mstange]]

The dependence on those prefs is not intentional.

Comment 2

[Arpad Borsos [:Swatinem]]

http://hg.swatinem.de/tinderboxpushlog/rev/67994c46fbcd
This falls back to a plain JS object if there is no local/globalStorage.

Comment 3

[Markus Stange [:mstange]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/67994c46fbcd

Thanks Arpad, and it would be good to mention the bug number in the commit message next time.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I poked Markus about deploying this, which meant I got to test it :-)

Unfortunately, the fix doesn't seem to work. :-(

I checked in both Camino-1.9.2-experimental-debug and Fx3.6 with fresh profiles, and only toggled cookies to "Ask" (network.cookie.lifetimePolicy to 1), and there's no change in loading-but-nothing-happening-behavior.  There don't appear to be any useful messages in the console.log/Error Console, either.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you've only set "Ask for cookies" ("network.cookie.lifetimePolicy", 1), you can work around this bug by setting a cookie exception for tests.themasta.com.

That won't help kaie, though, because dom.storage.enabled being set to true still appears to be a sine qua non.

Comment 6

[Markus Stange [:mstange]]

We didn't catch the security exception when accessing window.localStorage.

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8b1eae29d7a6

Comment 7

[Kai Engert [:KaiE:]]

Thank you very much!
verified