Brad, is this a regression? Didn't you and John fix this last year?
Seems to be, though I don't know that I ever built or ran the tests before. John told me he did, and I believe him. I have a patch to fix it up, just cleaning it up now.
Created attachment 426730 [details] [diff] [review] patch this gets individual tests building and skips building wince_tester.c. I'm working on a follow on patch to make that work.
Assignee: wtc → bugmail
Attachment #426730 - Flags: review?
Attachment #426730 - Flags: review? → review?(wtc)
Comment on attachment 426730 [details] [diff] [review] patch r=wtc. I'll clean this up a bit when I check this in. Does this mean we can remove wince_tester.cpp now?
Attachment #426730 - Flags: review?(wtc) → review+
I guess so. The client/sever tests require some sort of harness to run them, but wince_tester doesn't provide that anyway. one edit for the attached patch is to change -PDB:$(@).pdb to -PDB:$(@:.exe=.pdb). Otherwise we end up with name.exe.pdb, which works but is ugly.
Created attachment 426776 [details] [diff] [review] patch v2 (checked in) I edited the patch a little bit and checked it in on the NSPR trunk (NSPR 4.8.4). I also removed nst_wince.h and wince_tester.cpp from CVS. Brad, your patch builds the NSPR tests with debugging code and debug symbols, even in optimized/release builds. I just wanted to make sure you know that. Checking in Makefile.in; /cvsroot/mozilla/nsprpub/pr/tests/Makefile.in,v <-- Makefile.in new revision: 1.63; previous revision: 1.62 done Checking in foreign.c; /cvsroot/mozilla/nsprpub/pr/tests/foreign.c,v <-- foreign.c new revision: 3.17; previous revision: 3.16 done Removing nst_wince.h; /cvsroot/mozilla/nsprpub/pr/tests/nst_wince.h,v <-- nst_wince.h new revision: delete; previous revision: 3.3 done Checking in socket.c; /cvsroot/mozilla/nsprpub/pr/tests/socket.c,v <-- socket.c new revision: 3.23; previous revision: 3.22 done Checking in thrpool_server.c; /cvsroot/mozilla/nsprpub/pr/tests/thrpool_server.c,v <-- thrpool_server.c new revision: 3.12; previous revision: 3.11 done Checking in tmocon.c; /cvsroot/mozilla/nsprpub/pr/tests/tmocon.c,v <-- tmocon.c new revision: 3.16; previous revision: 3.15 done Removing wince_tester.cpp; /cvsroot/mozilla/nsprpub/pr/tests/wince_tester.cpp,v <-- wince_tester.cpp new revision: delete; previous revision: 3.1 done Checking in y2ktmo.c; /cvsroot/mozilla/nsprpub/pr/tests/y2ktmo.c,v <-- y2ktmo.c new revision: 3.8; previous revision: 3.7 done
Attachment #426730 - Attachment is obsolete: true
Created attachment 426779 [details] [diff] [review] PDB file name change that Brad suggested in comment 5. Checking in Makefile.in; /cvsroot/mozilla/nsprpub/pr/tests/Makefile.in,v <-- Makefile.in new revision: 1.64; previous revision: 1.63 done
Brad, do you still have a follow-on patch, or can we mark this bug fixed now?
Status: NEW → ASSIGNED
Target Milestone: --- → 4.8.4
wtc, I'm going to mark this as fixed and do any follow on work in a new bug. I'd like to have something that can run the client/server tests, but its becoming obvious that it won't be a quick fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
I pushed the patches to mozilla-central in changeset 340e7ad3b8ef: http://hg.mozilla.org/mozilla-central/rev/340e7ad3b8ef
You need to log in before you can comment on or make changes to this bug.