545991 - Stop and Reload combine only when reload is placed before stop

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[bogas04]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1) Gecko/20100208 Firefox 3.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1) Gecko/20100208 Firefox 3.6

In Firefox 3.7 Alpha 1 Dev Preview , although stop and reload buttons are combined , but when we try to "Customize..." navigation bar , we are able to see the buttons separately. Further if we place reload after stop , then both are visible even after closing customize dialog(just like previous versions)



Reproducible: Always

Steps to Reproduce:
1.Right click on navigation bar
2.Click customize
3.Place reload next to stop
4.Close customize dialog by clicking done

Actual Results:  
Reload and Stop are visible separately after clicking "done" and are not combined

Expected Results:  
Reload and Stop should be combined and further should be visible as a single button when customizing navigation bar

Comment 1

[Matthias Versen [:Matti]]

You can of course see both buttons again because that is a feature for all that people who want 2 buttons.
Are you sure that there is nothing between the 2 buttons like a separator ?

Comment 2

[Matthias Versen [:Matti]]

ah, and that they only merge if reload is placed before stop is wanted
https://bugzilla.mozilla.org/show_bug.cgi?id=343396#c103

marking this bug invalid

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

If the two buttons are next to each other, regardless of the order, we should be combining them.

It's not clear to users why we only combine in one direction but not in the other.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

The code for the combined stop/reload can be found here, http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4148

It already handles one of the directions, it shouldn't be too hard to make it handle the other direction.

Comment 5

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Jared:

Weren't we planning on binding those two buttons so that they couldn't be broken up, like the zoom and back and forward buttons?

-Mike

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, you're right. Thanks for the correction.

Comment 7

[Dão Gottwald [::dao]]

(In reply to Mike Conley (:mconley) from comment #5)
> Jared:
> 
> Weren't we planning on binding those two buttons so that they couldn't be
> broken up, like the zoom and back and forward buttons?
> 
> -Mike

Please file a new bug for that.

Comment 8

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Filed bug 873042