546065 - Port bug 488608 and bug 490325 to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just copy (the useful part of) it

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 426866 [details] [diff] [review]
(Av1) Just copy (the useful part of) it

>-    make WINCE_SDK_DIR="$WINCE_SDK_DIR" TOPSRCDIR="$srcdir/mozilla" OBJDIR="$_pwdw/mozilla" -C $srcdir/mozilla/build/wince/tools
>+    make WINCE_SDK_DIR="$WINCE_SDK_DIR" TOPSRCDIR="_topsrcdir/mozilla" OBJDIR="$_pwdw/mozilla" -C $srcdir/mozilla/build/wince/tools

$_topsrcdir rather?

Also m-c has OGLES_SDK_DIR as well, (didn't investigate where that came from; yet; probably ok for another bug)

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Just copy (the useful part of) it [Checkin: Comment 5]

Av1, with comment 2 suggestion(s):
good catch! I thought there may be something wrong when I checked it but it looks like I was/am really to tired to have actually noticed :-<


(In reply to comment #2)
> Also m-c has OGLES_SDK_DIR as well, (didn't investigate where that came from;
> yet; probably ok for another bug)

Yep, I noticed but preferred to do that other port later:
this will mean a 2nd patch/bug but it looked easier to track (for me) atm.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 426875 [details] [diff] [review]
(Av2) Just copy (the useful part of) it
[Checkin: Comment 5]

> (In reply to comment #2)
> > Also m-c has OGLES_SDK_DIR as well, (didn't investigate where that came from;
> > yet; probably ok for another bug)
> 
> Yep, I noticed but preferred to do that other port later:
> this will mean a 2nd patch/bug but it looked easier to track (for me) atm.

No problem.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 426875 [details] [diff] [review]
(Av2) Just copy (the useful part of) it
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/8a7036180b5e