Closed
Bug 546171
Opened 14 years ago
Closed 14 years ago
lirasm: move VerboseWriter to the end of the pipeline
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)
Attachments
(1 file)
|
2.01 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
lirasm's VerboseWriter is currently at the start of the pipeline. With --optimize this leads to confusing output, because if an instruction is CSE'd it gets reprinted, eg: 0 = int 0 0 = int 0 the second 'int 0' isn't really there but the CSE filter passes back a reference to the first 'int 0' and that's what gets printed -- the same instruction gets printed twice. Moving VerboseWriter to the end of the pipeline will fix this because the second 'int 0' won't even reach it because CseFilter won't pass it on. This will make lirasm match TM's and TR's pipelines.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #426934 -
Flags: review?(stejohns)
|
||
Updated•14 years ago
|
Attachment #426934 -
Flags: review?(stejohns) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/projects/nanojit-central/rev/49a15d14c359
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: fixed-in-nanojit
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/7b1d42444f85
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7b1d42444f85
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•