Closed Bug 546273 Opened 10 years ago Closed 10 years ago

Form Assistant misses focus on profiles.yahoo.com.

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janpieniadz1, Assigned: vingtetun)

References

()

Details

(Whiteboard: formfill)

Attachments

(4 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2.2pre) Gecko20100209 Namoroka/3.6.2pre Fennec/1.0pre

Maemo 5
fennec_1.0~20100209013306_armel
xulrunner_1.9.2.2pre-20100209011315_armel


Reproducible: Always

Steps to Reproduce:
1. Navigate to http://profiles.yahoo.com
2. Log in to yahoo! service.
3. Tap on 'guestbook' (textarea) form and observe position on page.

Actual Results:  
Block zooming is invoked but specified area is not visible. See screenshots.

Expected Results:  
Block zooming is invoked and Form Assistant dialog is opened. 
Specified area (set on 'guestbook' form) is zoomed and centred on screen.
Attached image Result
Attached image Guestbook position.
Summary: Form Assistant misses focus on locale.yahoo.com. → Form Assistant misses focus on profiles.yahoo.com.
Confirmed on build:
Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2.2pre) Gecko20100215 Namoroka/3.6.2pre Fennec/1.1a2pre


Is this a regression of https://bugzilla.mozilla.org/show_bug.cgi?id=524978 ?
Assignee: nobody → 21
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: 21 → nobody
Component: Linux/Maemo → General
OS: Linux → All
QA Contact: maemo-linux → general
Hardware: Other → All
(In reply to comment #3)
> Confirmed on build:
> Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2.2pre) Gecko20100215
> Namoroka/3.6.2pre Fennec/1.1a2pre
> 
> 
> Is this a regression of https://bugzilla.mozilla.org/show_bug.cgi?id=524978 ?

It sounds like a different bug.

Actually this specific textarea give me a rect of [-9969,-9999,10919,70] which is a non-sense for me.
Assignee: nobody → 21
Attached patch PatchSplinter Review
(In reply to comment #4)
> (In reply to comment #3)
> > Confirmed on build:
> > Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2.2pre) Gecko20100215
> > Namoroka/3.6.2pre Fennec/1.1a2pre
> > 
> > 
> > Is this a regression of https://bugzilla.mozilla.org/show_bug.cgi?id=524978 ?
> 
> It sounds like a different bug.
> 
> Actually this specific textarea give me a rect of [-9969,-9999,10919,70] which
> is a non-sense for me.

Right.
I don't know why yahoo is doing that but the label for the textarea is at position [-9999, -9999] and this is why we fail to position the view.

This patch set a limit to the maximum distance between the label and the input.
Attachment #427026 - Flags: review?(mark.finkle)
Comment on attachment 427026 [details] [diff] [review]
Patch

>-        let width = labelRect.width + elRect.width + (elRect.x - labelRect.x - labelRect.width);
>-        return new Rect(labelRect.x, labelRect.y, width, elRect.height).expandToIntegers();
>+        let isClosed = Math.abs(labelRect.left - elRect.left) - labelRect.width < kDistanceMax &&
>+                       Math.abs(labelRect.top - elRect.top) - labelRect.height < kDistanceMax;

isClose, not isClosed


I'd like to see a few Form Assistant tests land with this bug please. Not hundreds, but a few would be good.
Attachment #427026 - Flags: review?(mark.finkle) → review+
This patch add the first test to FormHelper and also factorize a bit the browser-chrome test for the Helpers functions.

There is also some corrections for FormHelper i've found while writing the tests.
Attachment #427677 - Flags: review?(mark.finkle)
oups, I've forgot to add head.js to this patch.
Sorry for the spam
Attachment #427677 - Attachment is obsolete: true
Attachment #427680 - Flags: review?(mark.finkle)
Attachment #427677 - Flags: review?(mark.finkle)
Comment on attachment 427680 [details] [diff] [review]
tests + some minor bug corrections for FormHelper

works OK and all tests are green.
Attachment #427680 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/368b818ac3db
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This is not fixed on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2.2pre) Gecko/20100302 Namoroka/3.6.2pre Fennec/1.1a1

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100302 Namoroka/3.6.2pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a2pre) Gecko/20100302 Namoroka/3.7a2pre Fennec/1.1a2pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
pushed main patch:
http://hg.mozilla.org/mobile-browser/rev/eed680712995
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.