546329 - Latest tamarin-redux doesn't support oprofile profiling on linux

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[tom.deneau]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; InfoPath.2; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; MS-RTC LM 8)
Build Identifier: 

Although Edwin Smith has done the work to enable oprofile on a private branch, it is not in the mainline.

Reproducible: Always

Actual Results:  
Cannot build an oprofile verion from the mainline. 
(../configure.py --enable-oprofile not supported)

Expected Results:  
Should be able to build an oprofile verion from the mainline.

I've taken the code from the private oprofile branch that Edwin pointed me to and merged it with the mainline.  I could post that patch.

Comment 1

[Dan Smith]

If you've got the patch, please share!

Comment 2

[Edwin Smith]

Tom, anything to post?

Comment 3

[Edwin Smith]

Attachment: old patch to integrate with oprofile

This worked on arm-linux and x86, at least.

Comment 4

[Jimmy Bahuleyan]

Attachment: oprofile support for tamarin-redux

Old patch doesn't apply to TR. Newer one built on top of TR:r5157, tested on linux-x86_64. Probably will be replaced with jit-profile support from Bug #590911.

Comment 5

[Dan Smith]

Jimmy, status update?   Ready for review?  I'm tempted to retarget to Anza; let me know if you want  to land this immediately or not.  It is not required for Serrano but it would be good to close out this lingering item.

Comment 6

[Dan Smith]

Moving to Anza.

Comment 7

[Jimmy Bahuleyan]

(In reply to Jimmy Bahuleyan from comment #4)
> Created attachment 471823 [details] [diff] [review]
> oprofile support for tamarin-redux
> 
> Old patch doesn't apply to TR. Newer one built on top of TR:r5157, tested on
> linux-x86_64. Probably will be replaced with jit-profile support from Bug
> #590911.

This patch is now outdated. The _right way_ to do it would be to use the JITObserver from Bug #676669. So I'd recommend marking this bug as dependent on 676669; assuming that the JITObserver implementation for VTune and Oprofile does not go in with 676669, I didn't see it in the patch. Otherwise close this with a comment stating that it's fixed in 676669.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.