Unclosed <a name> in "Importance" header of fields.html

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Bugzilla-General
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: GPHemsley, Assigned: GPHemsley)

Tracking

3.4.5
Bugzilla 3.4
Bug Flags:
approval -
approval3.6 +
approval3.4 +

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
As mentioned in bug 529201 comment 4, the <a name> used in the "Importance" header of fields.html is unclosed.

I'll be filing a bug in a moment to propose the removal of all instances of <a name>, but, in the meantime, I recommend simply closing this instance.
(Assignee)

Comment 1

7 years ago
Created attachment 427012 [details] [diff] [review]
Fix runaway <a name> (with additional whitespace changes)

This patch fixes the runaway <a name> in fields.html. (It also automatically removed a bunch of trailing whitespace; the relevant change is at line 205.)
Assignee: general → gphemsley
Status: NEW → ASSIGNED
Attachment #427012 - Flags: review?
(Assignee)

Comment 2

7 years ago
Created attachment 427013 [details] [diff] [review]
Fix runaway <a name> (no whitespace changes)

Manually edited the diff to remove the whitespace changes.

Also available on pastebin:
http://gphemsley.pastebin.com/f63ad7d0f
Attachment #427012 - Attachment is obsolete: true
Attachment #427013 - Flags: review?
Attachment #427012 - Flags: review?

Updated

7 years ago
Attachment #427013 - Flags: review? → review+

Comment 3

7 years ago
Approved immediately for 3.6 and 3.4, but for HEAD I'm holding on my other fields.html patch.
Flags: approval?
Flags: approval3.6+
Flags: approval3.4+
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> Approved immediately for 3.6 and 3.4, but for HEAD I'm holding on my other
> fields.html patch.

Indeed, although this is a patch against head, it becomes unnecessary once the patch for bug 529201 (attachment 425729 [details] [diff] [review]) is applied.

Comment 5

7 years ago
So no commit for 3.8 if I understand comment 4 correctly.
Flags: approval? → approval-

Comment 6

7 years ago
Yeah, that's right.

Comment 7

7 years ago
Thanks for the fix. :-) It was strange to see part of the paragraph highlighted. :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified template/en/default/pages/fields.html.tmpl
Committed revision 6981.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.4/                         
modified template/en/default/pages/fields.html.tmpl
Committed revision 6726.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.