Closed Bug 546338 Opened 14 years ago Closed 14 years ago

Unclosed <a name> in "Importance" header of fields.html

Categories

(Bugzilla :: Bugzilla-General, defect)

3.4.5
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: GPHemsley, Assigned: GPHemsley)

References

()

Details

Attachments

(1 file, 1 obsolete file)

As mentioned in bug 529201 comment 4, the <a name> used in the "Importance" header of fields.html is unclosed.

I'll be filing a bug in a moment to propose the removal of all instances of <a name>, but, in the meantime, I recommend simply closing this instance.
This patch fixes the runaway <a name> in fields.html. (It also automatically removed a bunch of trailing whitespace; the relevant change is at line 205.)
Assignee: general → gphemsley
Status: NEW → ASSIGNED
Attachment #427012 - Flags: review?
Manually edited the diff to remove the whitespace changes.

Also available on pastebin:
http://gphemsley.pastebin.com/f63ad7d0f
Attachment #427012 - Attachment is obsolete: true
Attachment #427013 - Flags: review?
Attachment #427012 - Flags: review?
Attachment #427013 - Flags: review? → review+
Approved immediately for 3.6 and 3.4, but for HEAD I'm holding on my other fields.html patch.
Flags: approval?
Flags: approval3.6+
Flags: approval3.4+
(In reply to comment #3)
> Approved immediately for 3.6 and 3.4, but for HEAD I'm holding on my other
> fields.html patch.

Indeed, although this is a patch against head, it becomes unnecessary once the patch for bug 529201 (attachment 425729 [details] [diff] [review]) is applied.
So no commit for 3.8 if I understand comment 4 correctly.
Flags: approval? → approval-
Yeah, that's right.
Thanks for the fix. :-) It was strange to see part of the paragraph highlighted. :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified template/en/default/pages/fields.html.tmpl
Committed revision 6981.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.4/                         
modified template/en/default/pages/fields.html.tmpl
Committed revision 6726.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.