Closed Bug 546376 Opened 10 years ago Closed 10 years ago

Remove pointless plusses in pinstripe/global/jar.mn

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
I can't even figure out where they came from, since the file landed from the Aviary Branch, where it landed as an unhelpful no-bug checkin that didn't seem to be removing any other jar.mn that had to override things, but pinstripe is not jarring into an existing jar that already has a global/, so there's no need to be overriding the file that isn't ever going to already be there.

Patch is on top of attachment 427072 [details] [diff] [review] from bug 520364, so I don't bit rot myself.
Attachment #427073 - Flags: review?(dao)
Attachment #427073 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/5dd3f323fa37
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
(In reply to comment #0)
> I can't even figure out where they came from, since the file landed from the

I suspect a cut and paste operation from a universal diff output and someone forgot to remove the +'s.
You need to log in before you can comment on or make changes to this bug.