Display avm and asc version when running runtests.py.

VERIFIED FIXED

Status

Tamarin
Tools
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Chris Peyer, Assigned: Chris Peyer)

Tracking

Details

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
Nice-to-have: display the avm and asc versions when running runtests.py.
(Assignee)

Comment 1

9 years ago
Created attachment 427213 [details] [diff] [review]
Display avm and asc version in header

Patch to display version info in header.

Asc version is only displayed if -f or --rebuildtests is enabled, as otherwise we have no way of knowing what compiler version was used for existing .abc files.

Also cleaned up a little bit of code in performance/runtests.py that was using if len(var) > 0 to just test for the var.
Attachment #427213 - Flags: review?(brbaker)
(Assignee)

Updated

9 years ago
Attachment #427213 - Flags: review?(brbaker) → review?(dschaffe)

Updated

9 years ago
Attachment #427213 - Flags: review?(dschaffe) → review+

Comment 2

9 years ago
Comment on attachment 427213 [details] [diff] [review]
Display avm and asc version in header

looks good.  I would run the patch through the sandbox to make sure winmo or platforms with no avm version work ok.  it would be nice if an abc embedded the version of compiler was used to build it.
(Assignee)

Comment 3

9 years ago
Pushed to redux changeset:   3854:3411b0f0a17d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED
(Assignee)

Comment 4

9 years ago
Created attachment 428285 [details] [diff] [review]
the vm variable name was incorrectly reused and therefore was being set in winmobile builds mistakenly to the filename.

Fix for winmo redux failure
Attachment #428285 - Flags: review?(dschaffe)

Updated

9 years ago
Attachment #428285 - Flags: review?(dschaffe) → review+
(Assignee)

Comment 5

9 years ago
Pushed to redux: changeset:   3877:c6931403257e
You need to log in before you can comment on or make changes to this bug.