Closed Bug 546629 Opened 14 years ago Closed 14 years ago

Wrong comment in the npruntime sample plugin source code

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: spsarolkar, Unassigned)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

fix the comment
1.64 KB, patch
jaas
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/532.5 (KHTML, like Gecko) Chrome/4.0.249.89 Safari/532.5
Build Identifier: mozilla1.9.2  mozilla/ modules/ plugin/ sdk/ samples/ npruntime/ npp_gate.cpp

Sample npruntime plugin provided with the mozilla source code contains misleading comment which causes confusion in new plugin developers referring to that example. Example located at path mozilla/ modules/ plugin/ sdk/ samples/ npruntime/ npp_gate.cpp . 

URL: http://mxr.mozilla.org/mozilla1.9.2/source/modules/plugin/sdk/samples/npruntime/npp_gate.cpp (Its at line number 144 to 152)  

Reproducible: Always
Attached file Replaced a comment (obsolete) — 
I have changed the respective comment and attached that file.
URL: http://mxr.mozilla.org/mozilla1.9.2/s... → http://mxr.mozilla.org/mozilla-centra...
Component: General → Plug-ins
QA Contact: general → plugins
Hardware: x86 → All
Summary: Wrong comment in the npruntime plugin source code → Wrong comment in the npruntime sample plugin source code
Version: unspecified → Trunk
Attached patch fix the comment — — Splinter Review 

        Attachment #427317 -
        Attachment is obsolete: true

        Attachment #427968 -
        Flags: review?(joshmoz)

    
  

        Attachment #427968 -
        Attachment is patch: true

        Attachment #427968 -
        Attachment mime type: application/octet-stream → text/plain

    
  

        Attachment #427968 -
        Flags: review?(joshmoz) → review+

    
    

    
  
Checked in: http://hg.mozilla.org/mozilla-central/rev/beb0ffcd0694

Thanks for the report!
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: