546753 - Enforce presence of an email address in the system

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, enhancement)

Description

[Toby Elliott [:telliott]]

The Weave Server's registration component contains the following code within mysql.php line 99: function create_user($password, $email = "")
The entire function is written to allow users to be created without a corresponding e-mail address. There are many areas of the application that won't operate correctly without an e-mail address. Therefore, either these areas should be modified to operate in lieu of an e-mail address, or it should be required data in order to call this function.

Comment 1

[Toby Elliott [:telliott]]

Now enforcing email.

http://hg.mozilla.org/labs/weaveserver-registration/rev/4af2c123877b

Les, can you review, please? Note that we're not doing any form of email validation, since it's trivial for someone to get around it. If we want email verification in accounts, we'll need to open it as a new feature.

Comment 2

[Les Orchard [:lorchard]]

Looks good to me.