546759 - Make sure weave_metadata collections_get returns an array

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Toby Elliott [:telliott]]

The Weave Server's synchronization component contains the following code within weave_metadata.php lines 144 and 145:
$this->collections_get(); return $this->_collections[$collection];
If collections_get fails, or any other issue occurs such that the _collections array doesn't have a value at the $collection index, then the above code will fail. If an attacker were to cause this erroneous behavior to occur, then they may find a way to make the failure advantageous to them.

Comment 1

[Toby Elliott [:telliott]]

Fixed in http://hg.mozilla.org/labs/weaveserver-sync/rev/45308253a45d

Les, please review.

Comment 2

[Toby Elliott [:telliott]]

also http://hg.mozilla.org/labs/weaveserver-sync/rev/858e2212d242

(found a corner case)

Comment 3

[Les Orchard [:lorchard]]

Looks like it does what it says on the tin.

Comment 4

[Toby Elliott [:telliott]]

live in the 2/25/10 push. There may be a new version of this before we actually flip the switch on Memcache, though