Closed Bug 546765 Opened 14 years ago Closed 14 years ago

njcpudetect.h needs love for OSX-on-ARM

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P3)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
ARM
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Q3 11 - Serrano

People

(Reporter: stejohns, Assigned: stejohns)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 file, 2 obsolete files)

Patch v3
720 bytes, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
Turns out that XCode doesn't follow the gcc practice of defining __ARM_ARCH__, so we need to add the special symbols it uses.
Attached patch Patch (obsolete) — — Splinter Review 
Assignee: nobody → stejohns

        Attachment #427446 -
        Flags: review?(nnethercote)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2 (obsolete)
        — 
          — Splinter Review
      

    


  
Same, but without the rogue semicolon

        Attachment #427446 -
        Attachment is obsolete: true

        Attachment #427449 -
        Flags: review?(nnethercote)

        Attachment #427446 -
        Flags: review?(nnethercote)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v3
        — 
          — Splinter Review
      

    


  
Sigh, helps if I attach the right file...

        Attachment #427449 -
        Attachment is obsolete: true

        Attachment #427451 -
        Flags: review?(nnethercote)

        Attachment #427449 -
        Flags: review?(nnethercote)

    
    

    
  
Comment on attachment 427451 [details] [diff] [review]
Patch v3

Does OS X even run on ARM?

        Attachment #427451 -
        Flags: review?(nnethercote) → review+

    
    

    
  
(In reply to comment #4)
> (From update of attachment 427451 [details] [diff] [review])
> Does OS X even run on ARM?

CocoaTouch: iPhone, etc.

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/0fdff97d5150

BTW it's better to use the core/Nanojit product/component pair for Nanojit bugs.
Status: NEW → ASSIGNED
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey

    
  
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → Future

    
  
Target Milestone: Future → flash10.2

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/0fdff97d5150
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin

    
  
Flags: flashplayer-bug-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: