546807 - Tabs from other computers: "Restore Session"

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Fritz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: 1.0.1

After Firefox crashes and you get "Restore Session" tab, that tab will sync and be shown on other computers.  The behavior is odd when you click the links and it doesn't show tabs to be restored from remote computer but from the local computer.

There should be two options for how to fix this that I can see:
1) Don't sync that tab
2) If you sync the tab also sync the data for lost tabs from the remote computer

Reproducible: Always

Comment 1

[Ed Lee :Mardak]

What url is showing up? about:sessionrestore ?

Comment 2

[Fritz]

Yes, about:sessionrestore is showing up.  I marked it as trivial, because it isn't of great importance.  And it might be marked as WONT FIX if you won't.  But, I do think it'd add functionality if possible to be able to access the session restore data from another computer if possible.  I made a bug because I found it somewhat bizarre.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I say we make this bug "should not sync about:sessionrestore" - we definitely don't want to sync it because without the formdata it's a useless page.

As for syncing whole sessions, that's a larger, far more complicated & daunting task.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

adds about:sessionrestore to the default filter list

Comment 5

[Ed Lee :Mardak]

Comment on attachment 427494 [details] [diff] [review]
Patch v0.1

At one point I was thinking about just blocking all about: uris. Are there any that would be useful across computers? about:config kinda, anything else?

Comment 6

[Fritz]

There are some--most add-on based, though.  About:Ubiquity or About:me could be up because you want to remember something to do with them.  Some of them will pose the same oddities as about:sessionrestore--that is, you will be getting the data from the main computer not the target computer even though you're opening tab "from target computer".

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #5)
> Are there any that would be useful across computers? about:config kinda, anything else?

Apart from about:sessionrestore, I don't think any of the other ones have a way to cause adverse effects. about:sessionrestore is also the only one that will show up without the user specifically typing it in the urlbar. On Minefield, go to about:about to see

about:privatebrowsing would be weird to sync, but unless that one is explicitly typed, it won't ever be open & synced (normal time that's show is when entering private browsing, but I think we stop syncing then, or should)

Fritz is right though about some add-on specific ones being potentially confusing.

Comment 8

[Mike Connor [:mconnor]]

Let's just not sync about:*, I can't see any of them being useful to sync.

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2

filter out about:.*

Comment 10

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/labs/weave/rev/d048474006f3
Filter out all about:* urls vefore syncing, including the specific case here: about:sessionrestore.