Closed Bug 546808 Opened 13 years ago Closed 13 years ago

focusing a link title on the result page of google.fr should highlight the entire link

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
Fennec 1.1
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file, 2 obsolete files)

Patch v0.2
1.63 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
Steps to reproduce:
 * go to google.com
 * search for "test"
 * on the first result, press the left button (or your finger) over the link but on the area where "test" appear in bold

Actual result:
 * Only the bold part of the link is highlight

Expected result:
 * All the link is highlight
Attachment #427491 - Flags: review?(webapps)
Attached patch Patch (obsolete) — — Splinter Review 
Updated patch.
Attachment #427491 - Attachment is obsolete: true
Attachment #442666 - Flags: review?(mark.finkle)
Attachment #427491 - Flags: review?(webapps)
Comment on attachment 442666 [details] [diff] [review]
Patch

OK, I am over my fear of this patch. I do want to re-evaluate how we do tap highlighting in general.

Unbitrot this patch for another review
Attached patch Patch v0.2 — — Splinter Review 

        Attachment #442666 -
        Attachment is obsolete: true

        Attachment #476084 -
        Flags: review?(mark.finkle)

        Attachment #442666 -
        Flags: review?(mark.finkle)

        Attachment #476084 -
        Flags: review?(mark.finkle) → review+
Whiteboard: [fennec-checkin-postb1]

    
    

    
  
pushed:
http://hg.mozilla.org/mobile-browser/rev/c57c94a6ae69
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb1]

    
    

    
  
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.