546808 - focusing a link title on the result page of google.fr should highlight the entire link

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Steps to reproduce:
 * go to google.com
 * search for "test"
 * on the first result, press the left button (or your finger) over the link but on the area where "test" appear in bold

Actual result:
 * Only the bold part of the link is highlight

Expected result:
 * All the link is highlight

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Updated patch.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 442666 [details] [diff] [review]
Patch

OK, I am over my fear of this patch. I do want to re-evaluate how we do tap highlighting in general.

Unbitrot this patch for another review

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/c57c94a6ae69

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre