TM: remove scary live connect crap from call path

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
/*
         * XXX this makes no sense -- why convert to function if clasp->call?
         * XXX better to call that hook without converting
         *
         * FIXME bug 408416: try converting to function, for API compatibility
         * if there is a call op defined.
         */
        if ((ops == &js_ObjectOps) ? clasp->call : ops->call) {
            ok = clasp->convert(cx, funobj, JSTYPE_FUNCTION, &v);
            if (!ok)
                goto out2;

            if (VALUE_IS_FUNCTION(cx, v)) {
                /* Make vp refer to funobj to keep it available as argv[-2]. */
                *vp = v;
                funobj = JSVAL_TO_OBJECT(v);
                parent = OBJ_GET_PARENT(cx, funobj);
                goto have_fun;
            }
        }
(Assignee)

Comment 1

9 years ago
Mike, what is the chance that we will need liveconnect for 1.9.3?
(Assignee)

Comment 2

9 years ago
Created attachment 427563 [details] [diff] [review]
patch
Assignee: general → gal
(Assignee)

Updated

9 years ago
Attachment #427563 - Flags: review?(brendan)
Comment on attachment 427563 [details] [diff] [review]
patch

Bet this breaks LiveConnect, or once would have. Let's find out, on tm and m-c.

/be
Attachment #427563 - Flags: review?(brendan) → review+
(Assignee)

Comment 4

9 years ago
Blah, forgot to quote the bug # in the commit.

http://hg.mozilla.org/tracemonkey/rev/a4df44da864c
(Assignee)

Updated

9 years ago
Whiteboard: fixed-in-tracemonkey

Comment 5

9 years ago
This caused ecma/GlobalObject/15.1-2-n.js to crash.

regression changeset: 38099:a4df44da864c user: Andreas Gal <gal@mozilla.com> date: Fri Feb 19 17:31:44 2010 -0800 summary: Remove LiveConnect kludge from call path (1.9.3 will not have LiveConnect according to jst, r=brendan).
(Assignee)

Updated

9 years ago
Depends on: 547483

Comment 6

9 years ago
http://hg.mozilla.org/mozilla-central/rev/a4df44da864c
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.