Only allow clients to issue delete records

RESOLVED FIXED in 1.2

Status

Cloud Services
Firefox Sync: Crypto
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
blocking-weave1.2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.54 KB, patch
mconnor
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Right now delete is an empty payload, but the server can send that for any record. We can ensure that the client issued the delete by encrypting the payload.

Would it be okay to just tag the data as delete in plaintext for the server to clean, but still somehow prove that only somebody with access issued the delete?

A bonus would be to avoid replay deletes too.
(Assignee)

Updated

8 years ago
Depends on: 549635
(Assignee)

Updated

8 years ago
Flags: blocking-weave1.2+
Summary: Only allow clients to issue delete records but allow servers to clean them up → Only allow clients to issue delete records
Target Milestone: --- → 1.2
(Assignee)

Updated

8 years ago
Blocks: 550588
(Assignee)

Comment 1

8 years ago
Created attachment 430776 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #430776 - Flags: review?(mconnor)
(Assignee)

Updated

8 years ago
Depends on: 545517
(Assignee)

Updated

8 years ago
Blocks: 549635
No longer depends on: 549635
(Assignee)

Comment 2

8 years ago
Created attachment 431449 [details] [diff] [review]
v1.1
Attachment #430776 - Attachment is obsolete: true
Attachment #431449 - Flags: feedback?(edilee)
Attachment #430776 - Flags: review?(mconnor)
(Assignee)

Updated

8 years ago
Attachment #431449 - Flags: feedback?(edilee) → review?(mconnor)

Updated

8 years ago
Attachment #431449 - Flags: review?(mconnor) → review+

Updated

8 years ago
Whiteboard: [has patch][has review]
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/labs/weave/rev/c8d528f14dab
Don't specially serialize/not encrypt delete records and store the deleted flag as part of the cleartext payload.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in before you can comment on or make changes to this bug.