Closed Bug 547048 Opened 14 years ago Closed 14 years ago

Only allow clients to issue delete records

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file, 1 obsolete file)

v1.1
5.54 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
Right now delete is an empty payload, but the server can send that for any record. We can ensure that the client issued the delete by encrypting the payload.

Would it be okay to just tag the data as delete in plaintext for the server to clean, but still somehow prove that only somebody with access issued the delete?

A bonus would be to avoid replay deletes too.
Depends on: 549635
Flags: blocking-weave1.2+
Summary: Only allow clients to issue delete records but allow servers to clean them up → Only allow clients to issue delete records
Target Milestone: --- → 1.2
Blocks: 550588
Attached patch v1 (obsolete) — — Splinter Review 
Assignee: nobody → edilee
Status: NEW → ASSIGNED

        Attachment #430776 -
        Flags: review?(mconnor)

    
  
Depends on: 545517

    
  
Blocks: 549635
No longer depends on: 549635

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.1
        — 
          — Splinter Review
      

    


  

        Attachment #430776 -
        Attachment is obsolete: true

        Attachment #431449 -
        Flags: feedback?(edilee)

        Attachment #430776 -
        Flags: review?(mconnor)

    
  

        Attachment #431449 -
        Flags: feedback?(edilee) → review?(mconnor)

        Attachment #431449 -
        Flags: review?(mconnor) → review+
Whiteboard: [has patch][has review]

    
    

    
  
http://hg.mozilla.org/labs/weave/rev/c8d528f14dab
Don't specially serialize/not encrypt delete records and store the deleted flag as part of the cleartext payload.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: