Build-time check that all directories in js/src/tests have jstests.list, all such directories are listed in their parents, no js file is omitted, etc.

NEW
Unassigned

Status

()

Core
JavaScript Engine
8 years ago
4 years ago

People

(Reporter: Waldo, Unassigned)

Tracking

({autotest-issue})

Trunk
All
Linux
autotest-issue
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
We seem to have perennial problems forgetting to add test files, and new test directories, to manifests.  We should put some sanity checks for all this in the build process so we don't have to manually track down these mistakes in the future.
The '-c' option of jstests.py should do most of this. Just need to make tinderbox output for it and add it to make check.
(Reporter)

Comment 2

8 years ago
I'd prefer if this sanity check weren't a "check" thing, rather just part of the "unnamed" Makefile target -- the earlier you find out about something like this, the better, especially if you write a really big patch that you think you've finished completely but then find the omitted test reveals some critical flaw that requires many changes to fix.

Comment 3

8 years ago
(In reply to comment #0)
> We seem to have perennial problems forgetting to add test files, and new test
> directories, to manifests.

BTW, why it was decided that the manifest must explicitly list all test files rather than including any js file or sub-directory by default and using explicit skip commands in manifest for entries that are not tests?

Comment 4

8 years ago
The reftest framework was leveraged thus bring the same manifest requirements.
(Assignee)

Updated

4 years ago
Assignee: general → nobody
You need to log in before you can comment on or make changes to this bug.