54718 - race: about:layout-dummy-request not always removed from loadgroup

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This seems to be a race condition in the async reflow code, as I'm only seeing
it (at least over the fast Netscape internet connection) when I artificially
slow down my LDAP code for debugging reasons.

50 or 60% of the time (when running in this artificially slow debugging mode)
the throbber isn't stopping when my LDAP channel removes itself from the
loadgroup.  After turning on loadgroup logging, it became apparent that this was
because the load group still contained about:layout-dummy-request.

To reproduce:

Add --enable-ldap to your .mozconfig file, then do "gmake -f client.mk build".

Edit line 424 of mozilla/directory/xpcom/base/src/nsLDAPConnection and turn on
the PR_Sleep call:

http://lxr.mozilla.org/seamonkey/source/directory/xpcom/base/src/nsLDAPConnection.cpp#424

Reconfigure and rebuild.

Do an ldap search.  One that I often use is
<ldap://memberdir.netscape.com/ou=member_directory,o=netcenter.com??sub?(sn=Rasputin)>. 
It's quick; once you see 7 entries, the search is done.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Urk, that first "gmake" command isn't necessary.

Comment 2

[Nisheeth Ranjan]

Nominating for rtm

Comment 3

[Nisheeth Ranjan]

Marking [rtm+ need info]

Comment 4

[Nisheeth Ranjan]

Unfortunately, given my rtm work load, I'm not going to be able to fix this for
rtm this week.  Marking rtm-.

Comment 5

[selmer (gone)]

adding mscott to CC

Comment 6

[Nisheeth Ranjan]

Bringing in load bugs that seem to be related to the dummy layout channel code 
into the 0.9 milestone.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

The build system has changed slightly; in addition to --enable-ldap, you'll also
want to add --enable-ldap-experimental.

Comment 8

[Nisheeth Ranjan]

Dan tested this again after waterson's recent fix to bug 53956 and he saw 
different problems.  Re-assigning this bug to him so that he can comment on what 
he saw and update the summary.

Dan, if you think that this bug is still related to the dummy layout request, 
please assign it back to me once you've added your comments on it.  Thanks!

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

I haven't had a chance to sort out the other nsLDAPChannel issue yet; this
doesn't need to make 0.9; moving out.

Comment 10

[Jussi-Pekka Mantere]

This code is only built in --enable-ldap-experimental, and the bug may already 
have been fixed by nisheeth.

Comment 11

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 12

[Asa Dotzler [:asa]]

don't move bugs that are in the 1.0 dependency tree. sorry.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Moving to my @netscape.com account and futuring; this code isn't even on in the
default build.

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

Assigning bugs that I'm not actively working on back to nobody; use
SearchForThis as a search term if you want to delete all related bugmail at
once.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Fixed, I assume, since we no longer have a dummy layout request.