Closed
Bug 547242
Opened 14 years ago
Closed 13 years ago
patcher-config-bump.pl needs to use Release::* from build/tools/lib/perl
Categories
(Release Engineering :: General, defect, P5)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
(Whiteboard: [automation])
Attachments
(1 file)
|
16.85 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
We created a couple new Perl modules as part of bug 492913, patcher-config-bump.pl should be updated to use GetProductDetails(), GetReleaseBlock(), BumpFilePath() instead of duplicating their functionality.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → bhearsum
|
|
Assignee | |
Comment 1•13 years ago
|
||
I had to update BumpFilePath and GetPrettyVersion, because the got out of date with the patcher-config-bum.pl versions (which is exactly why this bug is important!). Specifically, GetPrettyVersion didn't handle the new style Beta pretty names, and BumpFilePath didn't handle Mac platform exceptions correctly. The rest of the patch is just swapping them in where appropriate. The unit tests are broken, sadly, so to test I re-ran the patcher config bump/creation for: - 6.0b2 - 5.0.1 - 3.6.19 (minor & major) All post-bump configs matched the currently checked in copy.
Attachment #545978 -
Flags: review?(rail)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 545978 [details] [diff] [review] update & use Perl library functions Looks good.
Attachment #545978 -
Flags: review?(rail) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #545978 -
Flags: checked-in+
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•