547295 - XMLParser16 unescape does not handle lowercase hexadecimal sequences correctly

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[Werner Sharp]

Code in XMLParser::unescape needs to handle 'a' through 'f' as well as 'A' through 'F' for hexadecimal sequences:

            var tf:TextField = new TextField ();
            tf.text = "--" + new XML ("<foo>bar &#x20ac;</foo>");
            addChild (tf);

This code needs to be added after 'A' through 'F' check

			else if (ch >= 'a' && ch <= 'f')
			ch -= ('a' - 'A' + 7);

Comment 1

[Werner Sharp]

Attachment: simple patch for fix already in 10.1

Comment 2

[Steven Johnson]

http://hg.mozilla.org/tamarin-redux/rev/56fc8969219c

Comment 3

[Brent Baker]

Attachment: testcase

Comment 4

[Brent Baker]

Confirmed with old avmshell that it did not escape lowercase hex values

Comment 5

[Brent Baker]

testcase pushed in:
tr-argo ->  3840:eebec82bfb22
tr -> 4089:eebec82bfb22