547323 - "svg-integration" reftests subdir prevents tab-completion of "svg" reftests subdir

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

Whenever I try to run / edit / CD to a subdirectory off of /layout/reftests/svg/, my tab-completion always gets tripped up by the "svg-integration" sibling directory.

e.g.
 cd mo[TAB] --> mozilla/
    la[TAB] --> mozilla/layout/
    re[TAB] --> mozilla/layout/reftests/
    sv[TAB] --> mozilla/layout/reftests/svg[Terminal Bell]
        --> bash offers me both: svg/ & svg-integration/
        --> I have to manually type the "/" before going back into rapid-fire type+tab-complete mode.

It's a trivial issue, but it's a minor trip-up every time I try to e.g. run reftests in layout/reftests/svg/smil (or a subdirectory therein).

Would it be reasonable to move svg-integration to be a subdirectory off of /svg/?
 e.g.    layout/reftests/svg-integration
 becomes layout/reftests/svg/svg-integration

It looks like technically "svg-integration" is about applying SVG effects to non-SVG content -- but it is "svg-ish" in nature, and IMHO it'd still make some amount of sense to group it with the other svg reftests.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: patch: "hg mv svg-integration svg"

Trivial patch -- just generated from running:
> cd layout/reftests
> hg mv svg-integration/ svg/

Patch contains no actual code changes, just a bunch of git-style "rename from... rename to..." commands.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: patch: "hg mv svg-integration/ svg/" & update reftest.list

same patch, but now with updates to reftest.list files to reflect the move.

Comment 3

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/513f59058b0b