"svg-integration" reftests subdir prevents tab-completion of "svg" reftests subdir

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Whenever I try to run / edit / CD to a subdirectory off of /layout/reftests/svg/, my tab-completion always gets tripped up by the "svg-integration" sibling directory.

e.g.
 cd mo[TAB] --> mozilla/
    la[TAB] --> mozilla/layout/
    re[TAB] --> mozilla/layout/reftests/
    sv[TAB] --> mozilla/layout/reftests/svg[Terminal Bell]
        --> bash offers me both: svg/ & svg-integration/
        --> I have to manually type the "/" before going back into rapid-fire type+tab-complete mode.

It's a trivial issue, but it's a minor trip-up every time I try to e.g. run reftests in layout/reftests/svg/smil (or a subdirectory therein).

Would it be reasonable to move svg-integration to be a subdirectory off of /svg/?
 e.g.    layout/reftests/svg-integration
 becomes layout/reftests/svg/svg-integration

It looks like technically "svg-integration" is about applying SVG effects to non-SVG content -- but it is "svg-ish" in nature, and IMHO it'd still make some amount of sense to group it with the other svg reftests.
(Reporter)

Updated

8 years ago
Summary: "svg-integration" reftests directory prevents tab-completion of svg directory → "svg-integration" reftests subdir prevents tab-completion of "svg" reftests subdir
(Reporter)

Comment 1

8 years ago
Created attachment 427857 [details]
patch: "hg mv svg-integration svg"

Trivial patch -- just generated from running:
> cd layout/reftests
> hg mv svg-integration/ svg/

Patch contains no actual code changes, just a bunch of git-style "rename from... rename to..." commands.
Attachment #427857 - Flags: review?(roc)
(Reporter)

Comment 2

8 years ago
Created attachment 427859 [details] [diff] [review]
patch: "hg mv svg-integration/ svg/" & update reftest.list

same patch, but now with updates to reftest.list files to reflect the move.
Attachment #427857 - Attachment is obsolete: true
Attachment #427859 - Flags: review?(roc)
Attachment #427857 - Flags: review?(roc)
(Reporter)

Updated

8 years ago
Attachment #427859 - Attachment description: patch: "hg mv svg-integration svg" & update reftest.list → patch: "hg mv svg-integration/ svg/" & update reftest.list
Attachment #427859 - Attachment is patch: true
Attachment #427859 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/513f59058b0b
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.