547324 - problem with MDC's Linux symbol server download script (with patch)

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: General, defect)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a2pre) Gecko/20100218  Minefield/3.7a1pre
Build Identifier: 

https://developer.mozilla.org/en/Using_the_Mozilla_symbol_server links to http://people.mozilla.org/~tmielczarek/fetch-symbols.py

This script silently exits if the URL it retrieves is a 404.  I'm still figuring out why there is no http://symbols.mozilla.org/firefox/firefox-3.7a2pre-Linux-20100218030721-symbols.txt but the script should report an error.

Reproducible: Always

Steps to Reproduce:
1. Download that script under Linux, make it executable.
2. In a terminal enter the command
     fetch-symbols.py.org <path/to/my/firefox_dir>  http://symbols.mozilla.org/bogus /tmp
Actual Results:  
The script silently exits if the URL on the symbol server doesn't exist.

Expected Results:  
Some indication about the URL not existing.

I've e-mailed the script's owner.

Maybe this script should be moved to MDC as an attached file, with the color-coding and whatnot.  But maybe it's a larger security hole if a script you tell users to download and run lives on an editable wiki than on a user's web site.

Comment 1

[skierpage]

Attachment: patch for Python script

Check the status of the first URL request.  Also added some explanatory comment and link to MDC.

There's a urlretrieve() lower down that maybe also should be checked, but I haven't got that far.  urlopen() is deprecated in Python 3.0, maybe FancyURLOpen() that handles redirects is better.  I barely know Python 8-)

Comment 2

[(not currently active) Ted Mielczarek]

I've applied your patch to the script in the URL on my people.mozilla.com website.

Thanks!