547428 - SQL error when deleting a product and its related series when it has none

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Bodo-Merle Sandor]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2) Gecko/20100218 Ubuntu/10.04 (lucid) Firefox/3.6
Build Identifier: 

Trying to delete the test product from a fresh install (from bzr trunk), yield
the following error:

DBD::mysql::db do failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near ')' at line 1 [for Statement "DELETE FROM series WHERE  series_id IN
() "] at Bugzilla/Product.pm line 301
    Bugzilla::Product::remove_from_db('Bugzilla::Product=HASH(0x997a3e8)',
'HASH(0x9830598)') called at
/home/sbodo/workspace/foss/bzr/mozilla.org/bugzilla/editproducts.cgi line 235

So the delete statement should be executed only when the previous select yields
some result in $series_ids.


Reproducible: Always

Steps to Reproduce:
1. Try to Delete the Test product from a fresh bugzilla with series.
2.
3.

Comment 1

[Bodo-Merle Sandor]

Attachment: one liner fix for the SQL error

Comment 2

[Frédéric Buclin]

Affects 3.6 and tip only, due to bug 451716.

Comment 3

[Frédéric Buclin]

Comment on attachment 427942 [details] [diff] [review]
one liner fix for the SQL error

I will split it on two lines, but that's the right fix. r=LpSolit

Thanks for the patch!

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Product.pm
Committed revision 7011.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified Bugzilla/Product.pm
Committed revision 6986.