Closed Bug 547428 Opened 14 years ago Closed 14 years ago

SQL error when deleting a product and its related series when it has none

Categories

(Bugzilla :: Administration, task)

3.5.3
task
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: sbodomerle, Assigned: sbodomerle)

References

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2) Gecko/20100218 Ubuntu/10.04 (lucid) Firefox/3.6
Build Identifier: 

Trying to delete the test product from a fresh install (from bzr trunk), yield
the following error:

DBD::mysql::db do failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near ')' at line 1 [for Statement "DELETE FROM series WHERE  series_id IN
() "] at Bugzilla/Product.pm line 301
    Bugzilla::Product::remove_from_db('Bugzilla::Product=HASH(0x997a3e8)',
'HASH(0x9830598)') called at
/home/sbodo/workspace/foss/bzr/mozilla.org/bugzilla/editproducts.cgi line 235

So the delete statement should be executed only when the previous select yields
some result in $series_ids.


Reproducible: Always

Steps to Reproduce:
1. Try to Delete the Test product from a fresh bugzilla with series.
2.
3.
Affects 3.6 and tip only, due to bug 451716.
Assignee: administration → sbodomerle
Status: UNCONFIRMED → ASSIGNED
Depends on: 451716
Ever confirmed: true
Flags: blocking3.6+
Keywords: regression
Summary: SQL error on deleting a Product with series but there are no series entrys in the database → SQL error when deleting a product and its related series when it has none
Target Milestone: --- → Bugzilla 3.6
Version: unspecified → 3.5.3
Comment on attachment 427942 [details] [diff] [review]
one liner fix for the SQL error

I will split it on two lines, but that's the right fix. r=LpSolit

Thanks for the patch!
Attachment #427942 - Flags: review+
Flags: approval3.6+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Product.pm
Committed revision 7011.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Product.pm
Committed revision 6986.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: