547496 - Add IDs to some form elements

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

In order to add icons to some templates, I first need them to have IDs I can point to from the CSS files. Here is what I can do with this patch applied:

http://lpsolit.files.wordpress.com/2010/02/bugzilla_with_icons.png

Comment 1

[Frédéric Buclin]

Max, do you agree to take my patch for 3.6rc1? All it does is to add IDs to some HTML elements, so I see as being equivalent to your patches adding hooks to stable branches. :)

Comment 2

[Max Kanat-Alexander]

(In reply to comment #1)
> Max, do you agree to take my patch for 3.6rc1? All it does is to add IDs to
> some HTML elements, so I see as being equivalent to your patches adding hooks
> to stable branches. :)

  Hmm. Maybe. Did you check that the ids don't conflict with anything in the templates that use tabs.html.tmpl?

Comment 3

[Max Kanat-Alexander]

Maybe it would be safer to call them tab_[% name %] instead of just [% name %].

Comment 4

[Frédéric Buclin]

(In reply to comment #2)
>   Hmm. Maybe. Did you check that the ids don't conflict with anything in the
> templates that use tabs.html.tmpl?

Yes, I checked.


(In reply to comment #3)
> Maybe it would be safer to call them tab_[% name %] instead of just [% name %].

Don't know. For now, there is no conflict, and the names are hardcoded.

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> Don't know. For now, there is no conflict, and the names are hardcoded.

  Yeah, but just for future use. I don't think we'll id anything else as tab_<something>.

Comment 6

[Reed Loden [:reed]]

I see no reason why this couldn't land on the 3.6 branch, personally.

Comment 7

[Frédéric Buclin]

Attachment: patch, v2

%name% -> tab_%name%

I also added an ID for old and new charts in reports/menu.html.tmpl, which I omitted in my previous patch. Carrying pyrzak's r+ forward.

Happy now? :)

Comment 8

[Max Kanat-Alexander]

  Yeah, looks fine. :-)

Comment 9

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/admin.html.tmpl
modified template/en/default/global/tabs.html.tmpl
modified template/en/default/reports/menu.html.tmpl
Committed revision 7027.


I cannot commit to the 3.6 branch. I get an error when trying to.
bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium 'SmartSSHClientMedium(connected=True, username='[e-mail]', host='bzr.mozilla.org', port=None)' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

Comment 10

[Frédéric Buclin]

ok, works now.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified template/en/default/admin/admin.html.tmpl
modified template/en/default/global/tabs.html.tmpl
modified template/en/default/reports/menu.html.tmpl
Committed revision 6999.