Closed Bug 547518 Opened 11 years ago Closed 10 years ago

comm-central .../locales/Makefile.in resynchronization with Firefox

Categories

(MailNews Core :: Localization, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sgautherie, Unassigned)

References

()

Details

(Whiteboard: meta)

Attachments

(2 obsolete files)

I'll use this bug when I don't use the initial bugs.
Flags: in-testsuite-
*Identation synchronization for bug 494307 and bug 494576:
 make diff with FF more obvious.
*buildid:
 *SM: fixed in bug 539938.
 *TB: fixed in bug 470679.
 *SB: not fixed.
Attachment #428023 - Flags: review?(kairo)
Depends on: 494576, 496196
Attachment #433942 - Flags: review?(kairo)
Depends on: 511967
Comment on attachment 428023 [details] [diff] [review]
(Av1) Bug 496196 port final followup
[Moved to bug 554950]

1) Why are you stacking completely unrelated patches in a single, confusing bug?

2) What does this patch change? It's just a dumb multilining but no functional change, from what I see.
Whilst it may be more interesting to do it on a patch-by-patch basis, I'd strongly suggest just doing one patch per app to bring it up to date in one go. As this bug only affects one Makefile.in just doing a one patch "bring it up to date by matching browser" feels a lot less work than doing multiple patches and figuring out which bugs go where.

I had started a patch for mail/locales/Makefile.in which also switched to use the l10n.mk, I can probably dig that out later.
(In reply to comment #3)

> 1) Why are you stacking completely unrelated patches in a single, confusing
> bug?

See comment 0.

> 2) What does this patch change? It's just a dumb multilining but no functional
> change, from what I see.

Yes, that's it.

(In reply to comment #4)
> I'd
> strongly suggest just doing one patch per app to bring it up to date in one go.

I don't work like that. But anyone else is free to.
(In reply to comment #5)
> (In reply to comment #3)
> 
> > 1) Why are you stacking completely unrelated patches in a single, confusing
> > bug?
> 
> See comment 0.

Both "in the initial bug that was done by someone else" and "in another bug that merges unrelated stuff together" are not a good way to do things. One issue should have one bug and should have an explicit point where it can be marked FIXED as the specific issue it is about is resolved.

> > 2) What does this patch change? It's just a dumb multilining but no functional
> > change, from what I see.
> 
> Yes, that's it.

OK, then it should have a bug summary and description that tells about that.
(In reply to comment #5)
> (In reply to comment #4)
> > I'd
> > strongly suggest just doing one patch per app to bring it up to date in one go.
> 
> I don't work like that. But anyone else is free to.

That's unfortunate, as I won't review patches unless the bug report is clear to a single point and a good way to mark it FIXED once and for all at a certain point, ideally after one patch or a distinctive and clear series of patches is reviewed and applied.
Depends on: 554939
Attachment #433942 - Attachment description: (Bv1) Copy bug 511967 → (Bv1) Copy bug 511967 [Moved to bug 554939]
Attachment #433942 - Attachment is obsolete: true
Attachment #433942 - Flags: review?(kairo)
No longer depends on: 511967
Whiteboard: meta
Depends on: 554950
Assignee: sgautherie.bz → nobody
Status: ASSIGNED → NEW
No longer depends on: 470679, 494307, 494576, 496196, 539938
Attachment #428023 - Attachment description: (Av1) Bug 496196 port final followup → (Av1) Bug 496196 port final followup [Moved to bug 554950]
Attachment #428023 - Attachment is obsolete: true
Attachment #428023 - Flags: review?(kairo)
Depends on: 554993
This meta bug has outlived its usefulness, Thunderbird is very very close to the Firefox file, and SeaMonkey just finished its update (with some purposeful divergence) in Bug 554993, calling this fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: c-c .../locales/Makefile.in resynchronization with Firefox → comm-central .../locales/Makefile.in resynchronization with Firefox
You need to log in before you can comment on or make changes to this bug.