Closed Bug 547519 Opened 12 years ago Closed 12 years ago

enable building for windows mobile with a minimal mozconfig

Categories

(Firefox Build System :: General, defect)

ARM
Windows Mobile 6 Professional
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a3

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
because so many of our build options live in the mozconfig, developers are getting out of sync with what the buildbots are building (and out of sync with each other).  I think we should move most of these configuration options that are required to build into the configure as defaults.

this patch allows me to build xulrunner with the following options in my mozconfig:

ac_add_options --enable-application=xulrunner

#WINCE specific options
CROSS_COMPILE=1
ac_add_options --with-wince-sdk="c:/Program Files (x86)/Windows Mobile 6 SDK/PocketPC/"
ac_add_options --target=arm-wince-winmo
ac_add_options --enable-win32-target=WINCE
Attachment #428025 - Flags: review?(ted.mielczarek)
Could we autodetect the --enable-win32-target bit when the target is *-wince* ? (Either in the top-level configure or in NSPR's configure would probably be fine.) That'd remove one more argument.
Attached patch patch v.2Splinter Review
this should do the trick
Attachment #428025 - Attachment is obsolete: true
Attachment #428242 - Flags: review?(ted.mielczarek)
Attachment #428025 - Flags: review?(ted.mielczarek)
Comment on attachment 428242 [details] [diff] [review]
patch v.2

Better, thanks!
Attachment #428242 - Flags: review?(ted.mielczarek) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/c56daf6a663d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: nobody → bugmail
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a3
Comment on attachment 428242 [details] [diff] [review]
patch v.2

>+    ac_configure_args="$ac_configure_args --enable-win32-target=WINCE"

I want to port this patch to c-c,
but I'm puzzled by this line:
how does it actually work?

While there, I'm also puzzled by |AC_SUBST(ac_configure_args)|:
same question.
(In reply to comment #5)
> (From update of attachment 428242 [details] [diff] [review])
> >+    ac_configure_args="$ac_configure_args --enable-win32-target=WINCE"
> 
> I want to port this patch to c-c,
> but I'm puzzled by this line:
> how does it actually work?

that adds --enable-win32-target=WINCE to the list of configure arguments (as if it had passed in on the command line) primarily so that it can be passed on to nspr
 
> While there, I'm also puzzled by |AC_SUBST(ac_configure_args)|:
> same question.

that's not in the patch
(In reply to comment #6)

> that adds --enable-win32-target=WINCE to the list of configure arguments (as if
> it had passed in on the command line) primarily so that it can be passed on to
> nspr

I understand how the variable value is updated,
but where/how does it get passed to nspr?
Afaik, not at
http://mxr.mozilla.org/comm-central/source/mozilla/configure.in?mark=8588-8607#8584
and fwiw/aiuc in-tree nspr accepts WIN95/WINNT values only.

> that's not in the patch

I didn't say it was. The question just seemed "related".
Attachment #428242 - Flags: approval1.9.2.2?
Attachment #428242 - Flags: approval1.9.2.2? → approval1.9.2.3?
Comment on attachment 428242 [details] [diff] [review]
patch v.2

Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.
Attachment #428242 - Flags: approval1.9.2.4?
(In reply to Serge Gautherie (:sgautherie) from comment #5)
> I want to port this patch to c-c,

(In reply to Serge Gautherie (:sgautherie) from comment #7)

Never mind. WINCE support have since been removed (from m-c).
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.