Closed Bug 547656 Opened 12 years ago Closed 12 years ago

xptcall broken on mips o32 big endian

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The current xptinvoke and xptstubs fail massively on mips big endian because the current code doesn't handle the big endian case.

I wrote the patch a week ago and I don't remember exactly why I put most of the casts in xptcinvoke_mips.cpp, which seem pointless, but the patch has been verified to work in its current form, and to not break the little endian code.
Attachment #428153 - Attachment is patch: true
Attachment #428153 - Attachment mime type: application/octet-stream → text/plain
Attachment #428153 - Flags: review?(benjamin)
Attachment #428153 - Flags: review?(benjamin) → review+
Assignee: nobody → mh+mozilla
Keywords: checkin-needed
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/d92914f89484
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.