[HTML5][Patch] parser/htmlparser/tests/mochitest/test_bug418464.html fails

RESOLVED FIXED

Status

()

Core
HTML: Parser
P1
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
140607 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_bug418464.html | Should not have a form here - got [[object HTMLInputElement]], expected undefined
(Assignee)

Comment 1

8 years ago
Created attachment 428180 [details] [diff] [review]
Weaken the test not to require the first script to fail to find the form
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #428180 - Flags: review?(bzbarsky)
(Assignee)

Updated

8 years ago
Summary: [HTML5] parser/htmlparser/tests/mochitest/test_bug418464.html fails → [HTML5][Patch] parser/htmlparser/tests/mochitest/test_bug418464.html fails
Comment on attachment 428180 [details] [diff] [review]
Weaken the test not to require the first script to fail to find the form

I would prefer that this become todo_is(form1 instanceof HTMLFormElement).

r=bzbarsky with that.
Attachment #428180 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> (From update of attachment 428180 [details] [diff] [review])
> I would prefer that this become todo_is(form1 instanceof HTMLFormElement).

I can't make it a todo, since that would give an UNEXPECTED-PASS with the HTML5 parser. I could comment the line out and file a bug about uncommenting it in the future. Would your r hold for that?
(Assignee)

Comment 5

8 years ago
OK. The reminder bug is bug 547963.
(Assignee)

Comment 6

8 years ago
Thanks. Pushed:
http://hg.mozilla.org/mozilla-central/rev/62c81fdaeba1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.