547685 - [HTML5][Patch] parser/htmlparser/tests/mochitest/test_bug418464.html fails

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Henri Sivonen (:hsivonen)]

140607 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_bug418464.html | Should not have a form here - got [[object HTMLInputElement]], expected undefined

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Weaken the test not to require the first script to fail to find the form

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 428180 [details] [diff] [review]
Weaken the test not to require the first script to fail to find the form

I would prefer that this become todo_is(form1 instanceof HTMLFormElement).

r=bzbarsky with that.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to comment #2)
> (From update of attachment 428180 [details] [diff] [review])
> I would prefer that this become todo_is(form1 instanceof HTMLFormElement).

I can't make it a todo, since that would give an UNEXPECTED-PASS with the HTML5 parser. I could comment the line out and file a bug about uncommenting it in the future. Would your r hold for that?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sounds good, yeah.

Comment 5

[Henri Sivonen (:hsivonen)]

OK. The reminder bug is bug 547963.

Comment 6

[Henri Sivonen (:hsivonen)]

Thanks. Pushed:
http://hg.mozilla.org/mozilla-central/rev/62c81fdaeba1