547754 - Multiple ics attachments in e-mail are not transfered to calendar, only last one appears correctly

Status: NEW

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Stefan Haas]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.7) Gecko/20100104 Lightning/1.0b1 SeaMonkey/2.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.7) Gecko/20100104 Lightning/1.0b1 SeaMonkey/2.0.2

I receive mails with multiple ics attachments, each having one non-recurring event. Lightning display a message about a new event (German: Diese Nachricht enthält einen Termin) and a button to add to calendar (Zum Kalendar hinzufügen), but there are multiple events to add (no selection). Pressing the add button adds the last and discards the other events (all are structurally identical but different dates, subject and description, no Microsoft origin). As single-ics attachments work fine I assume that the attachment handler simply does not support multiple attachments.
After the attachment(s) have been processed, the lightning message is replaced (Dies Nachricht enthält einen Termin, der bereits verarbeitet wurde) and the button is gone.

Reproducible: Always

Steps to Reproduce:
1. Receive email with multiple (different) .ics attachments
2. Open mail and see lightning header above the e-mail
3. Press button and switch to calendar and see only one attachment


Expected Results:  
1. Status of e-mail attachment is updated
2. One calendar entry (last attachment)

Add all calendars instead of only the last

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Right, we support only one item at the moment, confirming.

Comment 2

[monperrus]

Bug still valid for 4.0b6. What's the status of this old bug?

Comment 5

[Peter Koch]

OK, bug 1285779 is a duplicate of this more than 6 year old bug. So I assume nobody is working on it. We ugently need this functionality so we might try to fix it ourself.

We already did some debugging on the server side. And we noticed that Lightning is sending PUT-requests to our CalDAV-server for each event that is containted in the Multi-Event ICS-attachement. But for every event Lighning is using the same UID, namely the UID from the last event. So the first event will be created with the UID of the last event, than the second event overwrites the first one and so on.

So my impression is: Lightning DOES support multi-event attachements. We don't have to add additional code to add this functionality. Maybe there's just a simple typo that has to be fixed.

Any ideas where to start?

Peter

Comment 6

[Ludwig Cottin]

Attachment: ics-invitations containing several events will be stored in the chosen calendar

Proposal how to deal with ics-invitations, that contain several events: Simply store those events to the chosen calender. This is already done in the release lighting product, but only for the last event found.

Comment 7

[[:MakeMyDay]]

Ludwig, thanks for submitting a patch. New contributors ore always welcome!

When submitting a patch, please make sure to also ask for review (or feedback, especially if you want an indication on the solution approach before preparing a final patch) so that soembody get aware of your work and the review process can be started to get it on it's way into the tree. Otherwise it may take some weeks or even months until it will be noticed, which was probably not what you wanted.

To ask for review/feedback, just set the '?' flag for the respective request type in the attachment upload UI and add a person to request. If you don't know whom to set, there's a reviewer suggestion list if you set r? - just pick one of the list.

Regarding your patch, I will take a look at it in the next couple of days and provide feedback.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

MakeMyDay, do you have some time to spare to look into this patch?
Ludwig, I'm sorry this has been taking so long. Unfortunately we are happy few and sometimes bugs go off the radar.

Comment 9

[monperrus]

FYI, I was just hit by this bug today on TB 54.

Comment 11

[Martin Schröder [:mschroeder]]

Relevant reference from bug 1243780:
RFC6047 4.4 - 4.5
https://tools.ietf.org/html/rfc6047#section-4.4

Comment 12

[[:MakeMyDay]]

Comment on attachment 8779363 [details] [diff] [review]
ics-invitations containing several events will be stored in the chosen calendar

Thanks for the patch and sorry, it took quite some time to get back to this.

The patch is working around the real problem, which is the limitaion of the itip processor to deal properly with multiple events at some places, by bypassing the itip processor for some cases. This will end in other downsides beyond the scope of this bug.

So, f- for this approach. Admittedly, fixing the root cause will be tougher then this approach.

Comment 15

[Boris 'pi' Piwinger]

I am not sure bug 1389014 is a dupe. This is about handling of attachments of type text/calendar. Those Thunderbird fails to open (e.g. by giving to Lightning).