547793 - Change testing/sisyphus/bin/tester.sh to use the new fix_stack_using_bpsyms.py [was: fix_macosx_stack.py]

Status: RESOLVED FIXED

(Testing Graveyard :: Sisyphus, defect)

Description

[Jesse Ruderman]

Please change testing/sisyphus/bin/tester.sh to use the new fix_macosx_stack.py.  fix_macosx_stack.py should work as a drop-in replacement for fix-macosx-stack.pl, but you might want to test that first.

The new script produces better stack traces for local debug builds.  For tinderbox builds, it neither helps nor hurts, but in the future it might help (see bug 547646).

(It can also be used as a python module, which provides a dramatic speedup if you run the same Firefox multiple times.  But since this caller isn't python, that isn't relevant.)

Comment 1

[Serge Gautherie (:sgautherie)]

Fwiw, see also bug 571443 where they want to make a further switch to fix_stack_using_bpsyms.py.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: bug-547793-fix-stacks.patch

copy fix_stack_using_bpsyms.py and use it to filter the log. This works on Mac and Linux, but not Windows.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: bug-547793-fix-stacks-handle-oom.patch:

If fix_stack_using_bpsyms.py fails due to an out of memory condition, simply copy the input to output without terminating the test abnormally. Additionally, remove the trailing newlines from the input line to prevent duplicate newlines from being emitted.

Comment 4

[Bob Clary [:bc] (inactive)]

http://hg.mozilla.org/automation/sisyphus/rev/72cc044ac098
http://hg.mozilla.org/automation/sisyphus/rev/4da2e290a1e8