547858 - [mozmill] default max of 6 items

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Tracy Walker [:tracy]]

Attachment: test case

write mozmill test case for Litmus "Autocomplete dropdown: default max of 6 items"
test case 8451

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 428306 [details] [diff] [review]
test case

>+    var historyService = Cc["@mozilla.org/browser/nav-history-service;1"].
>+                     getService(Ci.nsINavHistoryService);
>+    historyService.removeAllPages();

Can you please use the historyService instance provided by the PlacesAPI? Would be great if you can also update the other tests accordingly.

>+  // Load some pages to populate history. Default bookmarks will fill the rest.
>+  var websites = ['http://www.google.com/', 'http://www.mozilla.org', 'http://www.mozilla.org/projects/', 'http://www.bugzilla.org/', ];                 

Please use a separate line for each of the URL's.

>+  // Open the test page then about:blank to set up the test test environment
>+  for (var k = 0; k < websites.length; k++) {
>+    locationBar.loadURL(websites[k]);
>+    controller.waitForPageLoad();
>+  }

Please also use "for each" here as what we use in the other tests.

>+  // Get the visible results from the autocomplete list. Verify it is six
>+  var scrollBoxPath = '/id("main-window")/id("mainPopupSet")/id("PopupAutoCompleteRichResult")/anon({"anonid":"richlistbox"})';
>+  var scrollBoxElement = new elementslib.Lookup(controller.window.document, scrollBoxPath);
>+  var numberResultsVisible = scrollBoxElement.getNode().getNumberOfVisibleRows();
>+  controller.assertJS(numberResultsVisible == 6);

Please don't use any Lookup strings in your tests. All those instances will be part of the ToolbarAPI. Replace it with getElement from autoCompleteResults and feed it with "results" as type.

>+testCheckItemHighlight.meta = {litmusids : [8451]};

Please update the function name so it matches the given Litmus test.

Comment 2

[Tracy Walker [:tracy]]

Attachment: test case v2

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 428810 [details] [diff] [review]
test case v2

As talked on IRC yesterday, please upload the revised version.

Comment 4

[Tracy Walker [:tracy]]

Attachment: test case v3

Comment 5

[Tracy Walker [:tracy]]

arrrgh, this test case is broken on 1.9.1, getNumberOfVisibleRows() returns '0' instead of '6' as expected.  It works correctly on 1.9.2.  

Question: Is getNumberOfVisibleRows() not supported as a method of richlistbox elements on 1.9.1?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 429190 [details] [diff] [review]
test case v3

We have sorted those issues out yesterday. Tracy, just upload the two new tests for both branches.

Comment 7

[Tracy Walker [:tracy]]

Attachment: 3.6 test case

Comment 8

[Tracy Walker [:tracy]]

Attachment: 3.5 test case

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 433575 [details] [diff] [review]
3.6 test case

>+  // Load some pages to populate history. Default bookmarks will fill the rest.
>+  var websites = [
>+                  'http://www.google.com/',
>+                  'http://www.mozilla.org',
>+                  'http://www.mozilla.org/projects/',
>+                  'http://www.bugzilla.org/',
>+                 ];

The test should also work with no bookmarks listed in the auto-complete. For now you open only 4 different pages which is not enough. Please open at least 7 pages. For this test we should use the local web server. See the following test as an example:

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/testTabbedBrowsing/testOpenInBackground.js

>+  // Use type and sleep on each letter to allow the autocomplete to populate with results.
>+  for each (letter in testString) {
>+    locationBar.type(letter);
>+    controller.waitForEval('subject.isOpened == true', 10000, 100, locationBar.autoCompleteResults);
>+  }

Oh, this works now? I can remember that you have had problems with it. Please also update the comment.

>+  var autoCompleteResultsListNode = autoCompleteResultsList.getNode();
>+  controller.assertJS("subject.getNumberOfVisibleRows() == 6", autoCompleteResultsListNode);

Please make it one line. There is no need to declare autoCompleteResultsListNode.

>+var prefDialogSuggestsCallback = function(controller)
[...]
>+  controller.select(suggests, null, null, 0);
>+  controller.sleep(gDelay);
>+  PrefsAPI.preferencesDialog.close(controller, true);

Nit: Can you add an empty line after sleep?

Comment 10

[Tracy Walker [:tracy]]

(In reply to comment #9)

> 
> The test should also work with no bookmarks listed in the auto-complete. For
> now you open only 4 different pages which is not enough. Please open at least 7
> pages. 

It's not important what sort of items are used to populate the auto-complete list; just that there are more than 6 that match the typed string.  


> >+    controller.waitForEval('subject.isOpened == true', 10000, 100, locationBar.autoCompleteResults);
> >+  }
> 
> Oh, this works now? I can remember that you have had problems with it. Please
> also update the comment.

No, that's not working, sorry. I'll revert it back to a sleep
> 
> >+  var autoCompleteResultsListNode = autoCompleteResultsList.getNode();
> >+  controller.assertJS("subject.getNumberOfVisibleRows() == 6", autoCompleteResultsListNode);
> 
> Please make it one line. There is no need to declare
> autoCompleteResultsListNode.

Ack, another remnant of a screwed up repository that I missed. 

> >+  controller.sleep(gDelay);
> >+  PrefsAPI.preferencesDialog.close(controller, true);
> 
> Nit: Can you add an empty line after sleep?

Sure.

Comment 11

[Tracy Walker [:tracy]]

(In reply to comment #9)

> 
> The test should also work with no bookmarks listed in the auto-complete. For
> now you open only 4 different pages which is not enough. Please open at least 7
> pages. For this test we should use the local web server. See the following test
> as an example:
> 
> http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/testTabbedBrowsing/testOpenInBackground.js
> 

I realized that the default bookmarks may get deleted by some other test case. Thus causing this test to fail, as implemented.  Henrik, that sample of using a local web server doesn't shed much light for me.  Is it documented somewhere?

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't think that there is a documentation available yet on MDC. Poke Clint. For now store at least 7 different HTML files under a subfolder called 'files'. Then you can load those by using the way given in the example above.

Comment 13

[Tracy Walker [:tracy]]

Attachment: 3.6 test case v2

Comment 14

[Tracy Walker [:tracy]]

Attachment: 3.5 test case v2

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 434592 [details] [diff] [review]
3.6 test case v2

Sorry Trace, but with the refactoring of the preferencesDialog class this test needs a little adjustment. When you pull the most recent version of the tests you will see how it works now.

>+  PrefsAPI.preferencesDialog.open(prefDialogSuggestsCallback);

Can you also please move it into the test? UI actions shouldn't be handled in setupModule.

>+var prefDialogSuggestsCallback = function(controller)

This function also has to be updated regarding the refactoring.

>+testVisibleItemsMax.meta = {litmusids : [8451]};

You can leave that out now. We will not use it anymore to reference back Litmus tests. I will write a post tomorrow.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 434593 [details] [diff] [review]
3.5 test case v2

Same for this patch.

Comment 17

[Tracy Walker [:tracy]]

Attachment: patch_testVisibleItemMax [checked in]

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 435965 [details]
patch_testVisibleItemMax [checked in]

That one wasn't a patch. But I have created one and landed it on default. When running the test with Firefox 3.5 it will fail on all platforms. So we need another version for 1.9.1.

http://hg.mozilla.org/qa/mozmill-tests/rev/cca2b98b253c

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aaron, could you please have a look at the 3.5 failure? Looks like we need a little different version here.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #19)
> Aaron, could you please have a look at the 3.5 failure? Looks like we need a
> little different version here.

I think we should file a new bug on it.

Tracy, what happened with the Litmus test for 4.0? Got it removed completely? I can't find it. But I have updated the 3.5 and 3.6 tests on Litmus.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ah got it. It was 10439.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.