547859 - Wrong sort order for Address column

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Mats Palmgren (inactive)]

Wrong sort order for Address column.

STEPS TO REPRODUCE
1. Load the URL (or any other signature that has different values in the
   Address column)
2. click on the column head "Address"

ACTUAL RESULTS
Sorted in alphabetical order

EXPECTED RESULTS
Sorted on hex value

This is important to me since I want to be able to quickly estimate
how many are null-pointer crashes.

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Fixed in sandbox; awaiting #522232 commit.

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Committing with fix in #522232.  Please test on stage to verify it works for you.

==

Deleting       application/views/common/list_topcrashers_old.php
Sending        application/views/report/do_list.php
Sending        js/socorro/report_list.js
Transmitting file data ..
Committed revision 1977.

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Mats, can you please verify that this took care of your problem?  Thanks!

Comment 4

[Mats Palmgren (inactive)]

I still see the problem at the URL.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Corresponding query on stage is https://crash-stats.stage.mozilla.com/report/list?version=Firefox%3A3.6&build_id=&query_search=signature&query_type=exact&query=&date=&range_value=2&range_unit=weeks&process_type=all&plugin_field=&plugin_query_type=&plugin_query=&do_query=&signature=XPCWrappedNative%3A%3AIsValid()&missing_sig=&page=1

The sort order is definitely different than production; whether the new order is the correct order I can't say.

Very Lengthy Aside: I have to keep digging around to find stage when trying to verify things; the only reason I found it here was because Austin happened gave me the URL in the last bug of mine he asked me to verify after I asked a question in response to his cryptic-to-an-outsider previous comment ;)

If the stage URL were provided every time when asking for verification on bugs filed by non-Socorro team members, that would probably help with verifications and with people trying to verify fixes that are only on stage against the old code on production, which is what I think happened here.  I've updated my bookmark for stage (from an old, discontinued stage site to the current one) so that I'll find it in the future, but not everyone will have my bookmark.

Comment 6

[Mats Palmgren (inactive)]

The sort order is still wrong at the stage URL in the last comment.

Comment 7

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 2 for 547859

Found the issue.  Created a parser that allows provides hex to integer conversion for sorting.  Sending to ozten for code review.

Comment 8

[Austin King [:ozten]]

Comment on attachment 445289 [details] [diff] [review]
Patch 2 for 547859

I tested BADA55 and it came back true r+

Comment 9

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Austin.  Committing.  This will be available for testing on stage shortly.  See comment 5 for an url with which to test.  

Testing this bug may be dependent on bug #565905 being implemented on stage. 

This bug is slated to rollout with the 1.7 Socorro release in 2 weeks.

==

Sending        webapp-php/js/socorro/report_list.js
Transmitting file data .
Committed revision 2084.