Closed Bug 547862 Opened 14 years ago Closed 6 years ago

Consider moving cached method name out of MethodInfo class

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: mike, Unassigned)

Details

Low priority:  For bug 547066, I added a member Stringp "_methodName" to class MethodInfo that caches the method name the first time someone asks for it.  However, this costs 8 bytes per MethodInfo (4 bytes for the pointer, plus another 4 bytes since MMgc ends up rounding up in this case).  This affects any player build that defines AVMPLUS_SAMPLING, which includes all builds of AIR plus the debugger builds of the Flash Player.

Since there are lots and lots of MethodInfos, and this memory is taken whether or not the user is profiling, we should consider seeing if we can move this method name somewhere else: Possibly a hash table mapping MethodInfo to its name, hanging off the Sampler class.
Flags: flashplayer-qrb+
Target Milestone: --- → Future
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.