547961 - Impossible to add comments if you are logged in the site

Status: VERIFIED FIXED

(Websites Graveyard :: opentochoice.org, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

1/ be logged in wordpress (as an admin for me)
2/ try to add a comment

expected result:
comment added

actual result:
nothing happens on clicking the submit button. If I log out, the button works.

Comment 1

[Iacopo Benesperi [:iacchi]]

Now, that's funny. Is it possible to have the list of plugin installed in WP to make some local tests?

Comment 2

[Staś Małolepszy :stas]

Iacopo: http://viewvc.svn.mozilla.org/vc/projects/choice/trunk/wp-content/plugins/

Comment 3

[Iacopo Benesperi [:iacchi]]

Thanks.

So, the problem is surely in the theme: same WP installation, with the default theme commenting works fine, with the website theme it doesn't.
Now, we have to understand where the problem is in the code.

Comment 4

[Iacopo Benesperi [:iacchi]]

Found the bug. In file comments.php line 84:

<button id="btn_commentSubmit" class="submit-comment" name="submit" type="submit" tabindex="4"><?php _e('submit','choice'); ?></button>

must be changed with:

<button id="submit" class="submit-comment" name="submit" type="submit" tabindex="4"><?php _e('submit','choice'); ?></button>

Possible explanation: WP need the id of the button to be "submit" to work properly. If you're not logged everything works because the author data (name, mail) are within the form, so the id of the button isn't important. If you're logged the author data are fetched from the database, and WP need the "submit" id to understand that it must fetch data from the database.

Comment 5

[Javier Morales]

The problem was in the client side validation. This was fixed by Andres Garcia.

Comment 6

[Iacopo Benesperi [:iacchi]]

May I ask you, just out of curiosity, which piece of code did you change? I'd love to learn something from this. Thanks!

Comment 7

[Staś Małolepszy :stas]

r63266 might have some answers, but I'm not sure :)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://opentochoice.stage.mozilla.com/2010/02/new-post-in-english/#comment-171.