54798 - Save All Attachments appends "(Not Downloaded)" to files

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P2)

Description

[Brian Ryner (not reading)]

The attachment list displays "(Not Downloaded)" next to attachments which have
not been downloaded.  This is fine, but this text is also getting appended to
the filenames if you use Save All Attachments.  This is bad, because it
completely invalidates the file extension, which some OS's use to identify file
type.

Assigning to myself because I have a patch.  CC'ing mscott to review.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

accepting, nominating.

Comment 3

[Scott MacGregor]

ugghh that's not good. your proposed patch looks good to me.

Comment 4

[Peter Trudelle]

This will appear as data loss to naive users, since they won't be able to access
the contents by opening the document. rtm+ need info, remove 'need info' upon
review/approval. Proper review/approval protocol is a=<email> and r=<email> by
the reviewer, in the bug report.

Comment 5

[Scott MacGregor]

sr=mscott

Comment 6

[jefft]

r=jefft

Comment 7

[Phil Peterson]

PDT marking [rtm++]

Comment 8

[Brian Ryner (not reading)]

checked in on branch and trunk.

Comment 9

[pmock]

Verified as fixed on branch build of win32, linux, and macos using the following 
builds:
 win32 commercial seamonkey build 2000-101109-mn6 installed on P500 Win98
 linux commercial seamonkey build 2000-101109-mn6 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-101110-mn6 installed on G3/400 OS 9.04

Comment 10

[Asa Dotzler [:asa]]

verified with 122705 win32 on NT4
verified with 122710 linux on redhat6.2
verified with 122708 mac on OS9

saving all attachments saves attachments with correct names.
removing vtrunk and setting status to VERIFIED