If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Save All Attachments appends "(Not Downloaded)" to files

VERIFIED FIXED

Status

MailNews Core
MIME
P2
critical
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rtm++] r=jefft, sr=mscott)

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
The attachment list displays "(Not Downloaded)" next to attachments which have
not been downloaded.  This is fine, but this text is also getting appended to
the filenames if you use Save All Attachments.  This is bad, because it
completely invalidates the file extension, which some OS's use to identify file
type.

Assigning to myself because I have a patch.  CC'ing mscott to review.
(Assignee)

Comment 1

17 years ago
Created attachment 15908 [details] [diff] [review]
patch
(Assignee)

Comment 2

17 years ago
accepting, nominating.
Status: NEW → ASSIGNED
Keywords: correctness, rtm

Comment 3

17 years ago
ugghh that's not good. your proposed patch looks good to me.

Comment 4

17 years ago
This will appear as data loss to naive users, since they won't be able to access
the contents by opening the document. rtm+ need info, remove 'need info' upon
review/approval. Proper review/approval protocol is a=<email> and r=<email> by
the reviewer, in the bug report.
Priority: P3 → P2
Whiteboard: [rtm+ need info]

Comment 5

17 years ago
sr=mscott

Comment 6

17 years ago
r=jefft
Whiteboard: [rtm+ need info] → [rtm+ need info] r=jefft, sr=mscott
(Assignee)

Updated

17 years ago
Whiteboard: [rtm+ need info] r=jefft, sr=mscott → [rtm+] r=jefft, sr=mscott

Comment 7

17 years ago
PDT marking [rtm++]
Whiteboard: [rtm+] r=jefft, sr=mscott → [rtm++] r=jefft, sr=mscott
(Assignee)

Comment 8

17 years ago
checked in on branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

17 years ago
QA Contact: esther → pmock

Comment 9

17 years ago
Verified as fixed on branch build of win32, linux, and macos using the following 
builds:
 win32 commercial seamonkey build 2000-101109-mn6 installed on P500 Win98
 linux commercial seamonkey build 2000-101109-mn6 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-101110-mn6 installed on G3/400 OS 9.04
Keywords: vtrunk

Comment 10

17 years ago
verified with 122705 win32 on NT4
verified with 122710 linux on redhat6.2
verified with 122708 mac on OS9

saving all attachments saves attachments with correct names.
removing vtrunk and setting status to VERIFIED
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.