548157 - don't use iconViewerMenu.gif for viewers' menus in classic scheme

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: viewer context in both classic and modern

> .viewer-menu > .toolbarbutton-box > .toolbarbutton-dropmarker {
>   display: none;
> }

The toolbarbutton-class hasn't existed since December 2001, when Hewitt updated the modern theme but not classic.

Just use the dropmarker glyph.

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: lose the iconViewerMenu list-image and the broken "display: none" rule for the dropmarker

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

Er, the report should say "the toolbarbutton-box class hasn't existed...".

Comment 3

[[e-mail]]

Comment on attachment 428580 [details] [diff] [review]
lose the iconViewerMenu list-image and the broken "display: none" rule for the dropmarker

Assuming sdwilsh wants to do this (please wait for his review before asking me for sr on your next patch) you would remove the image and its jar packaging too.

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: remove files and tweak classic skin to use dropmarker glyph [Checkin: Comment 11]

Oops. That was my original plan, but I got it in my head that it was being used somewhere else.

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> (From update of attachment 428580 [details] [diff] [review])
> Assuming sdwilsh wants to do this (please wait for his review before asking me
> for sr on your next patch) you would remove the image and its jar packaging
> too.
So, you are going to know more about themeing than I am, so your input is appreciated before I do my review (oh gosh; deadlock!)

Comment 6

[[e-mail]]

As you can see, there was CSS to remove the dropmarker from the menubuttons leaving the icon, and this works in Modern, but what I don't know is whether you want to fix it for Classic or (as per the patch) to use the dropmarker only.

Comment 7

[Colby Russell :crussell (no longer Mozilla-ing)]

My intent was to use the dropmarker instead of the icon (the opposite of modern). It just seems to fit in better on classic.

Comment 8

[Shawn Wilsher :sdwilsh]

Modern/classic are things that only apply to Seamonkey, right?  If so, I'm going to defer to a Seamonkey peer since I have no preference and do not know how they want things like this.

Comment 9

[Colby Russell :crussell (no longer Mozilla-ing)]

Changes to classic will affect the appearance in most applications. It's the vanilla theme.

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 428749 [details] [diff] [review]
remove files and tweak classic skin to use dropmarker glyph
[Checkin: Comment 11]

I'm OK with this for classic.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 428749 [details] [diff] [review]
remove files and tweak classic skin to use dropmarker glyph
[Checkin: Comment 11]


http://hg.mozilla.org/dom-inspector/rev/8a9bd5331730