548161 - Don't add new strings to the theme for 0.75

Status: RESOLVED FIXED

(Websites Graveyard :: opentochoice.org, defect)

Description

[Staś Małolepszy :stas]

Attachment: Use default WP translations in index.php

Trying to give some feedback early on.

Wherever possible, please use the default WP messages for new string additions. This will allow us to make use of the official wordpress MO files we already have in wp-content/languages

For a complete list of such messages, please consult http://svn.automattic.com/wordpress-i18n/pot/tags/2.9.2/wordpress.pot

Attached is an sample patch. It changes "no comments" (which doesn't exist in wordpress.pot) to "No Comments" (which does). You can use CSS to style the letter down to lowercase.

For the "read full article" link. We can either use a default string like "More..." or "(more...)" or a string that we have in the 'choice' context: "Read the rest of this entry »"

Comment 1

[Javier Morales]

This has been fixed in stage. Please check it out.

Comment 2

[Staś Małolepszy :stas]

I saw a couple of commits to SVN related to this, but either of them was my patch :)

I'm looking at http://viewvc.svn.mozilla.org/vc/projects/choice/trunk/wp-content/themes/mozilla_choice/index.php?revision=63186&view=markup

This is good:
<?php _e('Read the rest of this entry &raquo;','choice'); ?>

But, this is not (but almost):

<div class="comment-count"><a title="<?php comments_number(__('No Comments','choice'),__('1 Comment','choice'),__('% Comments','choice')); ?>" href="<?php the_permalink() ?>"><strong><?php comments_number(__('No Comments','choice'),__('1 Comment','choice'),__('% Comments','choice')); ?></strong></a></div>

I think we should really leverage existing (official) Wordpress translations that we have in wp-content/languages. The code above uses custom strings for comments and puts them in the 'choice' context. They will show up in WPML and localizers will have to translate them.

So I'd suggest we remove the 'choice' context and just use plain __('% Comments').

Comment 3

[Javier Morales]

(In reply to comment #2)
This has been implemented in r63216

Comment 4

[Staś Małolepszy :stas]

Yep, thanks Javier. :)