548196 - add head.js support to browser chrome tests on 1.9.2 branch

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Add support for head.js to browser chrome tests. This was already done in mozilla-central. I am just backporting the support for head.js, not support for cleanup functions.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

added missing files

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Is there any reason not to just backport all of the m-c browser-chrome changes?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

The cleanup function code, added in bug 485269, depends on the changes made in bug 528469. Might even be some of bug 529860 mixed in there too.

I guess I could just copy the whole darn file and add the new test files. Just adding support for head.js was simpler.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yeah, I think we should port all the changes. They're all pretty self contained, I think. Will make backporting tests easier too.

Comment 5

[Marco Bonardo [:mak]]

(In reply to comment #3)
> The cleanup function code, added in bug 485269, depends on the changes made in
> bug 528469. Might even be some of bug 529860 mixed in there too.

well, the dependency is mostly code cleanup, but the pieces can be implemented apart. I think Gavin is correct here that porting all the changes is probably easier, there should not be any external dependency.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 3

Adds head.js support and cleanup function support to browser-chrome tests

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

all browser-head.js tests pass

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to try server and all browser-chrome tests passed

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4a273430d428