Closed Bug 548205 Opened 14 years ago Closed 14 years ago

Disallow embeddings reaching into our guts (part 1: jsnum.h)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

patch
7.07 KB, patch
brendan
: review+
Details | Diff | Splinter Review 
Content and DOM include jsnum.h because they want isfinite() and double_is_int32. Work around the former and offer an API for the latter and stop jsnum.h from being included. This greatly speeds up re-compilation time of firefox.

Disallowing the import of jsnum.h might be problematic for other embeddings. I can take out that #error #ifdef. Brendan what do you think?
Attached patch patch (obsolete) — — Splinter Review 
Assignee: general → gal

    
    

    
  
Comment on attachment 428636 [details] [diff] [review]
patch

This crosses a bunch of modules. I assume you can + for DOM and content as well.

        Attachment #428636 -
        Flags: review?(brendan)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #428636 -
        Attachment is obsolete: true

        Attachment #428636 -
        Flags: review?(brendan)

    
  

        Attachment #428641 -
        Flags: review?(brendan)

    
    

    
  
Been talking on iChat -- I advocated more EXPORTS trimming, gave other review comments about WIN32 not _WIN, JS_DoubleIsIntThatFitsInJsval (or should that end in ...JSVal?) instead of JS_DoubleIsInt32 (which is just misleading).

Argh, JS_DoubleIsInt31?

/be

    
    

    
  
Er, never mind on JS_DoubleIsInt32 -- the right name (I misremembered).

/be

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #428641 -
        Attachment is obsolete: true

        Attachment #428641 -
        Flags: review?(brendan)

    
  

        Attachment #428642 -
        Flags: review?(brendan)

    
    

    
  
Comment on attachment 428642 [details] [diff] [review]
patch

Assuming it tryservers well, r=me.

/be

        Attachment #428642 -
        Flags: review?(brendan) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/ea169ceb1162
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/ea169ceb1162
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
    

    
  
Interestingly, jsnum.h was added again in bug 636079...

    
  
Depends on: 662231

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: