Port Bug 526613 [Need a notification representing the end of nsISessionStore.setBrowserState operation] to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1a1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.76 KB, patch
Misak Khachatryan
: review+
Misak Khachatryan
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
From parent bug:

I was under the impression that sessionstore-windows-restored is the
notification used for this purpose, but as it turns out, that notification is
only sent during the initial restoring of the windows and tabs the first time
that the browser is starting up, and because many users (both in-tree and
possibly extensions as well) rely on it to detect the browser startup, we need
a new topic, which I'm going to tentatively name
sessionstore-browser-state-set.
(Assignee)

Comment 1

7 years ago
Created attachment 428654 [details] [diff] [review]
patch plus test v1
Attachment #428654 - Flags: superreview?(neil)
Attachment #428654 - Flags: review?(neil)

Updated

7 years ago
Attachment #428654 - Flags: superreview?(neil)
Attachment #428654 - Flags: superreview+
Attachment #428654 - Flags: review?(neil)
Attachment #428654 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
See bug 542946 comment 5 wrt the test name...
(Assignee)

Comment 3

7 years ago
Created attachment 432097 [details] [diff] [review]
same as above, renamed test files as agreed

same as above, renamed test files as agreed, carrying forward r+ sr+ from Neil, got approval for renaming on meeting over IRC.
Attachment #428654 - Attachment is obsolete: true
Attachment #432097 - Flags: superreview+
Attachment #432097 - Flags: review+

Comment 4

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/2c611970cf52 - thanks for your work!
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Depends on: 633724
You need to log in before you can comment on or make changes to this bug.