Closed
Bug 548551
Opened 14 years ago
Closed 13 years ago
remove scratchbox from our slaves
Categories
(Release Engineering :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: rail)
References
Details
(Whiteboard: [buildslaves][puppet][cleanup])
Attachments
(2 files)
782 bytes,
patch
|
mozilla
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
6.84 KB,
patch
|
jhford
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Nick recently noticed that the bindmount for the Scratchbox .ssh directory was getting remounted a bunch of times. I looked into this a bit and found that every time Puppet runs, it is remounted, with Puppet saying this in the log: Feb 25 05:47:18 mv-moz2-linux-ix-slave05 puppetd[2625]: (//Node[mv-moz2-linux-ix-slave05.build.mozilla.org]/base/centos5/Mount[/scratchbox/users/cltbld/home/cltbld/.ssh]/ensure) ensure changed 'present' to 'mounted' Feb 25 05:47:18 mv-moz2-linux-ix-slave05 puppetd[2625]: (//Node[mv-moz2-linux-ix-slave05.build.mozilla.org]/base/centos5/Mount[/scratchbox/users/cltbld/home/cltbld/.ssh]) Refreshing self While this doesn't seem to cause any harm, it isn't ideal and should be fixed. I think this issue stems from the fact that we have both a "File" and a "Mount" named "/scratchbox/users/cltbld/home/cltbld/.ssh", but it's hard to be sure. http://hg.mozilla.org/build/puppet-manifests/file/279ba6cded01/os/centos.pp#l52 http://hg.mozilla.org/build/puppet-manifests/file/279ba6cded01/os/centos.pp#l79
Comment 2•14 years ago
|
||
Maybe the File should be .../.ssh/known_hosts or something?
Updated•14 years ago
|
Assignee: nobody → dustin
Updated•13 years ago
|
Assignee: dustin → nobody
Comment 4•13 years ago
|
||
Morphing.
Priority: P5 → --
Summary: /builds/scratchbox/users/cltbld/home/cltbld/.ssh is continuously remounted on Linux slaves → remove scratchbox from our slaves
Updated•13 years ago
|
Blocks: maemo-tier3
Updated•13 years ago
|
Assignee: joduinn → nobody
Comment 5•13 years ago
|
||
We might want to doublecheck interpreter = ['/scratchbox/moz_scratchbox', '-d', '/builds/slave/nanojit-arm'] type calls in our -arm projects; that would suggest a dependency.
Comment 6•13 years ago
|
||
This is pretty important cleanup work IMO. Anyone want to take it on?
Priority: -- → P1
Whiteboard: [buildslaves][puppet] → [buildslaves][puppet][cleanup]
Comment 7•13 years ago
|
||
Is this the rm -rf of scratchbox on the slave drives?
Comment 8•13 years ago
|
||
Yes, but we should do it cleanly, which involves removing bindmounts and such. An rpm -e would do it once the rpm is fixed to uninstall cleanly. Can we wait until Lukas comments on comment 5 ?
Comment 9•13 years ago
|
||
(In reply to Aki Sasaki [:aki] from comment #8) > Yes, but we should do it cleanly, which involves removing bindmounts and > such. > An rpm -e would do it once the rpm is fixed to uninstall cleanly. > > Can we wait until Lukas comments on comment 5 ? Oops, this was Catlee!!! http://hg.mozilla.org/build/buildbotcustom/annotate/6d0cf1ef4ad6/misc.py#l3203 Also Coop fixed the nanojit one: http://hg.mozilla.org/build/buildbotcustom/annotate/6d0cf1ef4ad6/misc.py#l3133 Coop, Catlee, do you guys know what it will take to get rid of scratchbox here? Is it negotiating with the spidermonkey + nanojit folk?
Comment 10•13 years ago
|
||
(In reply to Aki Sasaki [:aki] from comment #9) > (In reply to Aki Sasaki [:aki] from comment #8) > > Yes, but we should do it cleanly, which involves removing bindmounts and > > such. > > An rpm -e would do it once the rpm is fixed to uninstall cleanly. > > > > Can we wait until Lukas comments on comment 5 ? > > Oops, this was Catlee!!! > http://hg.mozilla.org/build/buildbotcustom/annotate/6d0cf1ef4ad6/misc. > py#l3203 > Also Coop fixed the nanojit one: > http://hg.mozilla.org/build/buildbotcustom/annotate/6d0cf1ef4ad6/misc. > py#l3133 > > Coop, Catlee, do you guys know what it will take to get rid of scratchbox > here? > Is it negotiating with the spidermonkey + nanojit folk? Yup, we need to know if they can go without the qemu arm support
Comment 11•13 years ago
|
||
Recap: we're clear! Nanojit and SpiderMonkey don't need scratchbox. https://bugzilla.mozilla.org/show_bug.cgi?id=638349#c14 https://bugzilla.mozilla.org/show_bug.cgi?id=638349#c15 https://bugzilla.mozilla.org/show_bug.cgi?id=609413#c33 We probably need another bug to track turning off nanojit and spidermonkey scratchbox jobs; otherwise remove away!
Comment 12•13 years ago
|
||
We don't actually run arm spidermonkey, so this is the only thing we need.
Attachment #574633 -
Flags: review?(aki)
Updated•13 years ago
|
Attachment #574633 -
Flags: review?(aki) → review+
Updated•13 years ago
|
Attachment #574633 -
Flags: checked-in+
Updated•13 years ago
|
Flags: needs-reconfig?
Comment 15•13 years ago
|
||
(In reply to Aki Sasaki [:aki] (back nov 28) from comment #13) > This landed in this morning's reconfig. What left to do here?
Assignee: nobody → joduinn
Assignee | ||
Comment 18•13 years ago
|
||
Comment on attachment 576568 [details] [diff] [review] remove scratchbox Review of attachment 576568 [details] [diff] [review]: ----------------------------------------------------------------- I tested the patch on moz2-linux-slave51 several times switching clean manifests (to reinstall scratchbox) and my manifests to tests if they remove the package cleanly. I used the following tests: * grep scratchbox /etc/fstab, no output expected * mount | grep scratchbox, no output expected * /scratchbox symlink and /build/scratchbox directory shouldn't exist * ~cltbld/.ssh should be in place * "rpm -qa|grep scratchbox |wc -l" should retirn 0 ::: modules/packages/files/scratchbox-preun.sh @@ +14,5 @@ > + umount /home/cltbld/.ssh > + sleep 2 > +done > +rm -rf /builds/scratchbox > +rm -rf /scratchbox In ideal world the last 2 command should be run after removing the package. However, since it requires additional "target" and dependency and even if we run these commands before we remove the package it doesn't break anything, I decided to simplify the patch and put them here.
Comment 19•13 years ago
|
||
Comment on attachment 576568 [details] [diff] [review] remove scratchbox Review of attachment 576568 [details] [diff] [review]: ----------------------------------------------------------------- Cool. looks good to me ::: modules/packages/files/scratchbox-preun.sh @@ +14,5 @@ > + umount /home/cltbld/.ssh > + sleep 2 > +done > +rm -rf /builds/scratchbox > +rm -rf /scratchbox sgtm
Attachment #576568 -
Flags: review?(jhford) → review+
Assignee | ||
Comment 20•13 years ago
|
||
To be deployed tomorrow. Thanks, jhford!
Assignee | ||
Comment 21•13 years ago
|
||
Comment on attachment 576568 [details] [diff] [review] remove scratchbox http://hg.mozilla.org/build/puppet-manifests/rev/1b7919bfec4e
Attachment #576568 -
Flags: checked-in+
Assignee | ||
Comment 22•13 years ago
|
||
I checked the slaves today and forced update for the following (dev/pp) slaves: linux-ix-slave03 linux-ix-slave04 moz2-linux-slave04 moz2-linux-slave10 moz2-linux-slave51 mv-moz2-linux-ix-slave01 staging-puppet symlinked to manifests-CLEAN now. Die, scratchbox, die!!!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•