548681 - nsIPluginInstance.h/idl in XULRunner 1.9.2 pulls in nsString.h instead of nsStringGlue.h

Status: RESOLVED DUPLICATE of bug 512884

(Core Graveyard :: Embedding: APIs, defect)

Description

[Matt Hall]

User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MS-RTC LM 8; InfoPath.2; OfficeLiveConnector.1.4; OfficeLivePatch.1.3; .NET4.0C; .NET4.0E)
Build Identifier: ftp://ftp.mozilla.org/pub/xulrunner/releases/1.9.2/sdk/xulrunner-1.9.2.en-US.win32.sdk.zip

Embedding applications cannot include nsIPluginInstance.h/idl, as they pull in nsString.h which requires MOZILLA_INTERNAL_API. There was a pre-existing bug logged against this (https://bugzilla.mozilla.org/show_bug.cgi?id=512884), but it doesn't appear that the fix actually made it into XulRunner 1.9.2, which would be nice, so that customers do not have to alter their header files manually to fix the problem.

Reproducible: Always

Steps to Reproduce:
1. Build an embedding application against XulRunner 1.9.2 and #include nsIPluginInstance.h
Actual Results:  
#error :  Internal string headers are not available from external-linkage code.

(from nsStringFwd.h, since nsIPluginInstance.h #include's nsString.h instead of nsStringGlue.h)

Expected Results:  
Compile works fine and nsIPluginInstance.h #include's nsStringGlue.h instead (as it does in the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=512884 which is apparently not in XulRunner 1.9.2 SDK)