548754 - After uninstalling an add-on which has a button on an user defined toolbar an empty toolbar remains

Status: RESOLVED WONTFIX

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Martin Lemburg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.8) Gecko/20100202 Firefox/3.5.8 ( .NET CLR 3.5.30729; .NET4.0E)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.8) Gecko/20100202 Firefox/3.5.8 ( .NET CLR 3.5.30729; .NET4.0E)

I uninstalled an add-on, from which I used icons via the customization in a user defined toolbar.

The icons disappeared as expected and the user defined toolbar is empty.

Now choosing "customize" in the toolbar context menu has no effect anymore.

Reproducible: Always

Steps to Reproduce:
1. create user defined toolbar
2. put add-on icons onto this toolbar
3. uninstall add-on
4. restart firefox
Actual Results:  
an empty toolbar and a non-working "customize" toolbar command

Expected Results:  
the empty user defined toolbar should be deleted and the "customize" toolbar command should work

the empty user defined toolbar should be deleted and the "customize" toolbar command should work

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

About which addon are you talking?

Comment 2

[Martin Lemburg]

The add-on I'm talking about is: "Link Widgets 1.6.6"

Comment 3

[Martin Lemburg]

Here the line in localstore.rdf still containing the toolbar definition, while the icon provide don't exists anymore:

  <RDF:Description RDF:about="chrome://browser/content/browser.xul#customToolbars"
                   toolbar1="META links:linkwidget-top,linkwidget-up,linkwidget-first,linkwidget-prev,linkwidget-next,linkwidget-last,linkwidget-more-menu"

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Martin, can you please check again with Firefox 3.6? When I follow your steps from comment 0 I can see that an empty toolbar remains but the customize command still work. Can you verify that?

Comment 5

[Martin Lemburg]

Yes, Henrik, you are right. In FF3.6 the customization still works, even if there is nothing to customize in the now visually empty toolbar, because there is nothing to select.
In FF3.5.8 the customize dialog still does not come up.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Martin. Because it isn't a security related bug the additional issue for Firefox 3.5.x will not be fixed. But we will take care of the empty toolbar, which should be deleted.

Comment 7

[Ria Klaassen (not reading all bugmail)]

Could be a dupe of Bug 401666.

Comment 9

[:Gijs (he/him)]

We no longer support adding custom toolbars, so we won't improve our dying support for ones that have been carried around from previous profiles.