Closed Bug 548821 Opened 14 years ago Closed 14 years ago

XSync needed after XShmPutImage

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(3 files, 1 obsolete file)

In hardware mode we are not sending correct data to QGLWidget because it is not synced properly after XShmPutImage.
Attached patch XSync with QGLWidget (obsolete) — Splinter Review
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #429378 - Flags: review?(dougt)
Comment on attachment 429378 [details] [diff] [review]
XSync with QGLWidget

+        gIsQGLRendering = newView->viewport()->inherits("QGLWidget");

can viewport() be null?

why is an XSync required when using GL.  I don't really understand.
Blocks: 549975
I think we must call XSync always, otherwise we are painting wrong data.
Attachment #429378 - Attachment is obsolete: true
Attachment #430841 - Flags: review?(dougt)
Attachment #429378 - Flags: review?(dougt)
Summary: XSync needed after XShmPutImage in QGLWidget mode (-graphicssystem opengl) → XSync needed after XShmPutImage
Attachment #430841 - Flags: review?(dougt) → review+
Fixed
http://hg.mozilla.org/mozilla-central/rev/72bbe3137e1f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: