54899 - select Header in table cell property does not update table; not reflected properly in dialog

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[rubydoo123]

using comm build from 2000093020 on win98
1. open composer
2. insert table with several rows/columns -- enter text in cells
3. select a cell, display property dialog
4. select the cell to be header not normal
5. select ok

expected: the data should have been centered and bold
what happened: nothing, it remained as a td element.

Comment 1

[rubydoo123]

setting headers for tables is one of the most frequently down actions, this is a 
must fix

Kathy, please follow the checkin rules -- get a patch to fix the problems, get 
it super-reviewed, get module owner approval. The reviewer and module owner must 
make an entry in the bug, once all of that is done, remove the NEED INFO in the 
rtm+ block. I will then pop it to pdt for approval.

Comment 2

[Phil Peterson]

PDT agrees [rtm need info] until patch and code reviews are available.

Comment 3

[Kathleen :Brade]

this bug only happens if there is only one cell selected.  If you select a row, 

column, or more than one cell (like by pressing the command/control key) you 

won't see this bug.

Comment 4

[Kathleen :Brade]

Attachment: fix missing () and call code to convert from td to th

Comment 5

[Kathleen :Brade]

Also note that the current setting doesn't show up correctly in the dialog due
to "toLowerCase" not being "toLowerCase()"

Comment 6

[kinmoz]

sr=[e-mail]

Comment 7

[Simon Fraser [no longer active]]

r=sfraser

Comment 8

[Jim Roskind]

Given we're looking for small changes, with a big bang, why does the diff
include name changes (code cleanup?).  This sure seems like a waste to be
messing with at this point.  Is there something critical that is not obvious?

Comment 9

[rubydoo123]

yes, you can't change a cell from td to th - which is a big deal

Comment 10

[Simon Fraser [no longer active]]

On the variable name cleanup: there is a real danger of JS variable name 
conflicgts in our XUL/JS, because a global variable shares scope with global and 
unscoped variables in all other JS files included by the XUL files and overlays 
for the current window. This is an often-ignored danger, and it has led to real 
bugs. I strongly approve of this variable name change for safety and readability 
reasons.

Comment 11

[Jim Roskind]

I agree with Simon that cleanup is good, but chatting with him he agreed we
can't afford cleanup based regressions at this point.

I'll give a double plus on the smaller bug fix in the next 24 hours, so long as
the name change stuff is not included.  Please save the cleanup for landing on
the trunk after we get back to general CPD focus on the trunk (shouldn't be more
that a few weeks).

Comment 12

[Kathleen :Brade]

Attachment: previous patch without variable renamed

Comment 13

[Kathleen :Brade]

new patch attached without variable name change; waiting for jar's rtm++  :-)

Comment 14

[Michael La Guardia]

marking rtm++

Comment 15

[Kathleen :Brade]

fixed early this a.m. on branch (yesterday on trunk)

Comment 16

[sujay]

verified in 10/12 build.