If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Wrong return type from CSP inline-script check

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dveditz, Assigned: dveditz)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 429258 [details] [diff] [review]
fix return value

Natch is right in bug 515442 comment 15 -- the code ends up returning a boolean instead of a nsresult.

Notice the rest of the file doesn't use NS_ENSURE_ macros much, could change this to 
  if (NS_FAILED((rv = csp->etc))) {
    return rv;
  }
if preferred.
Attachment #429258 - Flags: review?(jonas)
Attachment #429258 - Flags: review?(jonas) → review+
(Assignee)

Updated

8 years ago
Assignee: nobody → dveditz
(Assignee)

Comment 1

8 years ago
http://hg.mozilla.org/mozilla-central/rev/0780abb1f723
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.